Skip to content

Conversation

@winniehell
Copy link
Contributor

@winniehell winniehell commented Aug 27, 2025

What does this PR do?

replace datetime.datetime.utcnow() with datetime.datetime.now(datetime.timezone.utc) to resolve deprecation warnings

see warning in Python documentation: https://docs.python.org/3.8/library/datetime.html#datetime.datetime.utcnow

@winniehell winniehell marked this pull request as ready for review August 27, 2025 10:09
@winniehell winniehell force-pushed the winniehell-replace-utcnow branch from 771e4f4 to e3258b0 Compare August 27, 2025 10:28
@winniehell
Copy link
Contributor Author

@willingc do you have time to take a look at this tiny change? it would safe us a few deprecation warnings in our logs 🙂

@winniehell
Copy link
Contributor Author

@MSeal do you have time to take a look at this?

Copy link
Member

@rgbkrk rgbkrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Not sure what's up with CI not reporting back.

@winniehell winniehell force-pushed the winniehell-replace-utcnow branch from e3258b0 to 54f3d76 Compare November 7, 2025 20:56
@winniehell
Copy link
Contributor Author

I tried to trigger CI with another push but it doesn't seem to help 🤷

@winniehell
Copy link
Contributor Author

https://github.com/nteract/papermill/actions/runs/19180999485 displays This workflow is awaiting approval from a maintainer in https://github.com/nteract/papermill/pull/823 for me:

grafik

@rgbkrk
Copy link
Member

rgbkrk commented Nov 7, 2025

Odd that can't trigger it from here. When I get back to my laptop I'll change the repo settings to modern GitHub actions so we can kick this off and clean up the backlog of PRs.

@winniehell
Copy link
Contributor Author

according to https://docs.github.com/en/actions/how-tos/manage-workflow-runs/approve-runs-from-forks, there should be an approve button here on the conversations tab though I'm not sure where or how it looks like

@winniehell
Copy link
Contributor Author

I took a look at the failing tests but the error doesn't seem related to the changes here:

FAILED papermill/tests/test_adl.py::ADLTest::test_create_adapter - AttributeError: <module 'azure.datalake.store.lib' from '/home/runner/work/papermill/papermill/.tox/py39/lib/python3.9/site-packages/azure/datalake/store/lib.py'> does not have the attribute 'auth'

@winniehell
Copy link
Contributor Author

ah, there is already an open issue for that: #825

@rgbkrk
Copy link
Member

rgbkrk commented Nov 13, 2025

Alright, I think you can now rebase this PR.

@winniehell winniehell force-pushed the winniehell-replace-utcnow branch from 54f3d76 to 9a723b4 Compare November 13, 2025 07:26
@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.99%. Comparing base (cb2eb37) to head (9a723b4).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #823      +/-   ##
==========================================
- Coverage   91.54%   90.99%   -0.56%     
==========================================
  Files          17       17              
  Lines        1621     1632      +11     
==========================================
+ Hits         1484     1485       +1     
- Misses        137      147      +10     
Files with missing lines Coverage Δ
papermill/engines.py 95.81% <100.00%> (-2.57%) ⬇️
papermill/parameterize.py 97.95% <100.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2be801d...9a723b4. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rgbkrk rgbkrk merged commit a79f3e7 into nteract:main Nov 13, 2025
12 checks passed
@rgbkrk
Copy link
Member

rgbkrk commented Nov 13, 2025

Thank you again @winniehell!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants