chore: shuffle around type declarations so native prover generation works better #3357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping to 3.0+ napi because otherwise typegen doesn't work right
added pass-by-ref to
External, otherwise napi doesn't compile right (this was fixed in 3.0+, we shouldn't be passing them by copy tbhmoved prover_index functions outside of the types.rs, since types.rs uses internal
Result, and we try to rename napi_bindgen::prelude::Result to NapiResult, but the typegeneration script looks for explicitlyResult<T>, it breaks the typegeneration. Bad library design