Update empty lists component to CardEmptyState #1932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaja-osojnik
requested review from
buberdds,
csillag,
lubej and
lukaw3d
as code owners
Deployed to Cloudflare Pages
|
kaja-osojnik
force-pushed
the
kaja/empty-lists
branch
from
29f9afd to
d8708d8
Compare
lukaw3d
reviewed
Apr 30, 2025
kaja-osojnik
force-pushed
the
kaja/empty-lists
branch
from
d8708d8 to
4cb042d
Compare
lukaw3d
reviewed
May 22, 2025
| const events = data?.data.events | ||
| if (isFetched && pagination.selectedPage > 1 && !events?.length) { | ||
| throw AppErrors.PageDoesNotExist | ||
| } |
Member
There was a problem hiding this comment.
Inconsistent error if user changes url and goes to a page that doesn't exist:
- txs https://pr-1932.oasis-explorer.pages.dev/mainnet/consensus/address/oasis1qpsjpe3tn5zhrv7ldmg2vfcuek4lkpva0ghwkv55?page=100
- events https://pr-1932.oasis-explorer.pages.dev/mainnet/consensus/address/oasis1qpsjpe3tn5zhrv7ldmg2vfcuek4lkpva0ghwkv55/events?page=100
Member
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
sapphire account:
txs empty due to filter: https://pr-1932.oasis-explorer.pages.dev/mainnet/sapphire/address/0x79F952376AaE242CE09e19870a5af18379bAb5B3?tx_method=roflmarket.InstanceCreate
lukaw3d
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a consistent use for empty lists across the site using CardEmptyState component.
Fixes: #1879
Before:
After:
