Skip to content

Update empty lists component to CardEmptyState #1932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kaja-osojnik wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update empty lists component to CardEmptyState #1932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changelog/1932.bugfix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Use EmptyState instead of CardEmptyState for empty lists.
15 changes: 13 additions & 2 deletions src/app/components/RuntimeEvents/RuntimeEventsDetailedList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,21 @@ export const RuntimeEventsDetailedList: FC<{
showTxHash: boolean
}> = ({ scope, events, isLoading, isError, pagination, showTxHash }) => {
const { t } = useTranslation()

if (isError) {
return <CardEmptyState label={t('event.cantLoadEvents')} />
}

if (isLoading) {
return <TextSkeleton numberOfRows={10} />
}

if (!events?.length) {
return <CardEmptyState label={t('event.cantFindMatchingEvents')} />
}

return (
<>
{isError && <CardEmptyState label={t('event.cantLoadEvents')} />}
{isLoading && <TextSkeleton numberOfRows={10} />}
{events &&
events.map((event, index) => (
<div key={`event-${index}`}>
Expand Down
6 changes: 2 additions & 4 deletions src/app/components/Transactions/ConsensusTransactionEvents.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { AppErrors } from '../../../types/errors'
import { NUMBER_OF_ITEMS_ON_SEPARATE_PAGE as limit } from '../../config'
import { ConsensusEventsList } from '../ConsensusEvents/ConsensusEventsList'
import { useSearchParamsPagination } from '../Table/useSearchParamsPagination'
import { EmptyState } from '../EmptyState'
import { CardEmptyState } from '../CardEmptyState'

export const ConsensusTransactionEvents: FC<{
transaction: Transaction
Expand All @@ -25,9 +25,7 @@ export const ConsensusTransactionEvents: FC<{
}

if (!events?.length && isFetched) {
return (
<EmptyState description={t('event.cantFindMatchingEvents')} title={t('event.noEvents')} light={true} />
)
return <CardEmptyState label={t('event.cantFindMatchingEvents')} />
}

return (
Expand Down
6 changes: 2 additions & 4 deletions src/app/pages/ConsensusAccountDetailsPage/ConsensusAccountEventsCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ import { ConsensusAccountDetailsContext } from './hooks'
import { NUMBER_OF_ITEMS_ON_SEPARATE_PAGE as limit } from '../../config'
import { LinkableCardLayout } from '../../components/LinkableCardLayout'
import { useSearchParamsPagination } from '../..//components/Table/useSearchParamsPagination'
import { EmptyState } from '../../components/EmptyState'
import { eventsContainerId } from '../../utils/tabAnchors'
import { CardEmptyState } from 'app/components/CardEmptyState'

const ConsensusAccountEventsList: FC<ConsensusAccountDetailsContext> = ({ scope, address }) => {
const { t } = useTranslation()
Expand All @@ -26,9 +26,7 @@ const ConsensusAccountEventsList: FC<ConsensusAccountDetailsContext> = ({ scope,
}
Copy link
Member

@lukaw3d lukaw3d May 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent error if user changes url and goes to a page that doesn't exist:

image

Copy link
Member

@lukaw3d lukaw3d May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inverted in sapphire:

image

Copy link
Member

@lukaw3d lukaw3d May 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

accounts pages: consensus

sapphire:

Copy link
Member

@lukaw3d lukaw3d May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sapphire account:

transfers: https://pr-1932.oasis-explorer.pages.dev/mainnet/sapphire/address/0x79F952376AaE242CE09e19870a5af18379bAb5B3/token-transfers?page=10
image

txs empty due to filter: https://pr-1932.oasis-explorer.pages.dev/mainnet/sapphire/address/0x79F952376AaE242CE09e19870a5af18379bAb5B3?tx_method=roflmarket.InstanceCreate

image


if (!events?.length && isFetched) {
return (
<EmptyState description={t('event.cantFindMatchingEvents')} title={t('event.noEvents')} light={true} />
)
return <CardEmptyState label={t('event.cantFindMatchingEvents')} />
}

return (
Expand Down
6 changes: 2 additions & 4 deletions src/app/pages/ConsensusBlockDetailPage/ConsensusBlockEventsCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ import { AppErrors } from '../../../types/errors'
import { NUMBER_OF_ITEMS_ON_SEPARATE_PAGE as limit } from '../../config'
import { LinkableCardLayout } from '../../components/LinkableCardLayout'
import { useSearchParamsPagination } from '../../components/Table/useSearchParamsPagination'
import { EmptyState } from '../../components/EmptyState'
import { ConsensusBlockDetailsContext } from '.'
import { ConsensusEventsList } from '../../components/ConsensusEvents/ConsensusEventsList'
import { eventsContainerId } from '../../utils/tabAnchors'
import { CardEmptyState } from 'app/components/CardEmptyState'

const ConsensusBlockEventsList: FC<ConsensusBlockDetailsContext> = ({ scope, blockHeight }) => {
const { t } = useTranslation()
Expand All @@ -26,9 +26,7 @@ const ConsensusBlockEventsList: FC<ConsensusBlockDetailsContext> = ({ scope, blo
}

if (!events?.length && isFetched) {
return (
<EmptyState description={t('event.cantFindMatchingEvents')} title={t('event.noEvents')} light={true} />
)
return <CardEmptyState label={t('event.cantFindMatchingEvents')} />
}

return (
Expand Down
6 changes: 2 additions & 4 deletions src/app/pages/RuntimeBlockDetailPage/RuntimeBlockEventsCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ import { LinkableCardLayout } from '../../components/LinkableCardLayout'
import { useSearchParamsPagination } from '../../components/Table/useSearchParamsPagination'
import { AppErrors } from '../../../types/errors'
import { RuntimeEventsDetailedList } from '../../components/RuntimeEvents/RuntimeEventsDetailedList'
import { EmptyState } from '../../components/EmptyState'
import { RuntimeBlockDetailsContext } from '.'
import { eventsContainerId } from '../../utils/tabAnchors'
import { CardEmptyState } from 'app/components/CardEmptyState'

const EventsList: FC<RuntimeBlockDetailsContext> = ({ scope, blockHeight }) => {
const { t } = useTranslation()
Expand All @@ -31,9 +31,7 @@ const EventsList: FC<RuntimeBlockDetailsContext> = ({ scope, blockHeight }) => {
const events = data?.data.events

if (!events?.length && !isLoading) {
return (
<EmptyState description={t('event.cantFindMatchingEvents')} title={t('event.noEvents')} light={true} />
)
return <CardEmptyState label={t('event.cantFindMatchingEvents')} />
}

return (
Expand Down