8366775: TestCompileTaskTimeout should use timeoutFactor

[mhaessig]

TestCompileTaskTimeout.java employs a timeout to test that methods compiled faster than a specified CompileTaskTimeout. However, it does not make use of the jtreg timeout factor, which lead to #26963 increasing the timeout to 2 s. This PR remedies this, by using the timeout factor and reducing the default timeout to 500 ms.

Testing:

• Github Actions
• tier1, tier2 linux-x64-debug, linux-x64, linux-aarch64-debug, linux-aarch64

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8366775: TestCompileTaskTimeout should use timeoutFactor (Bug - P4)

Reviewers

• Christian Hagedorn (@chhagedorn - Reviewer)
• Roberto Castañeda Lozano (@robcasloz - Reviewer)
• Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27094/head:pull/27094
$ git checkout pull/27094

Update a local copy of the PR:
$ git checkout pull/27094
$ git pull https://git.openjdk.org/jdk.git pull/27094/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27094

View PR using the GUI difftool:
$ git pr show -t 27094

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27094.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mhaessig! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mhaessig This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366775: TestCompileTaskTimeout should use timeoutFactor

Reviewed-by: chagedorn, rcastanedalo, mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 67 new commits pushed to the master branch:

• f10c85f: 8367027: java/lang/ProcessBuilder/Basic.java fails on Windows AArch64
• 0632617: 8367135: Test compiler/loopstripmining/CheckLoopStripMining.java needs internal timeouts adjusted
• a1ab12b: 8366854: Extend jtreg failure handler with THP info
• ... and 64 more: https://git.openjdk.org/jdk/compare/8c50bed86709a45615743dd7953b8c6861f1da0c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@mhaessig The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1d02b444)

[chhagedorn]

Looks reasonable, thanks for adjusting it again!

[robcasloz]

Looks good to me! Please check with the PPC port maintainers (and perhaps the maintainers of RISC-V, s390, and ARM32?) that this works in their environment.

[mhaessig]

@MBaesken, could you please have a look, since you filed the issue? Is the reduced default a problem on your side?

[MBaesken]

Is the reduced default a problem on your side?
I added the PR to our build/test queue. The reduced default should be okay for us.

[MBaesken]

Looks good, the adjustments seem to work for us.