Skip to content

Conversation

jaybhaskar
Copy link
Member

@jaybhaskar jaybhaskar commented Sep 14, 2025

Issue: JavaFX debug builds fail on Linux
The failure is permission issue on javascript core scripts that generates built in functions, the script has no write and execute permission permission.

Solution : Use copy of scripts not from JavaScriptCore source with right permission ( OWNER_EXECUTE).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8329874: JavaFX debug builds fail on Linux (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1902/head:pull/1902
$ git checkout pull/1902

Update a local copy of the PR:
$ git checkout pull/1902
$ git pull https://git.openjdk.org/jfx.git pull/1902/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1902

View PR using the GUI difftool:
$ git pr show -t 1902

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1902.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 14, 2025

👋 Welcome back jbhaskar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 14, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Ready for review label Sep 14, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 14, 2025

Webrevs

@kevinrushforth
Copy link
Member

Reviewers: @kevinrushforth @HimaBinduMeda

/reviewers 2

@kevinrushforth kevinrushforth self-requested a review September 15, 2025 12:10
@openjdk
Copy link

openjdk bot commented Sep 15, 2025

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I see that the test build has passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Ready for review
Development

Successfully merging this pull request may close these issues.

2 participants