Skip to content

8329874: JavaFX debug builds fail on Linux #1902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

8329874: JavaFX debug builds fail on Linux #1902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion modules/javafx.web/src/main/native/Source/JavaScriptCore/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1546,7 +1546,8 @@ if (CMAKE_COMPILER_IS_GNUCXX AND GCC_OFFLINEASM_SOURCE_MAP)
FILE_PERMISSIONS OWNER_EXECUTE OWNER_WRITE OWNER_READ GROUP_READ GROUP_WRITE GROUP_READ WORLD_READ
DESTINATION ${JavaScriptCore_SCRIPTS_DIR}
)
set(LowLevelInterpreter_LAUNCHER "${RUBY_EXECUTABLE} ${JavaScriptCore_SCRIPTS_SOURCES_DIR}/postprocess-asm")
#use copy not actual source
set(LowLevelInterpreter_LAUNCHER "${RUBY_EXECUTABLE} ${JavaScriptCore_SCRIPTS_DIR}/postprocess-asm")
else ()
set(LowLevelInterpreter_LAUNCHER "${RUBY_EXECUTABLE} ${JavaScriptCore_SCRIPTS_SOURCES_DIR}/postprocess-asm")
endif ()
Expand Down
4 changes: 2 additions & 2 deletions modules/javafx.web/src/main/native/Source/WTF/wtf/RefCounted.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ class RefCountedBase {
protected:
RefCountedBase()
: m_refCount(1)
#if ASSERT_ENABLED
#if ASSERT_ENABLED && !PLATFORM(JAVA)
, m_isOwnedByMainThread(isMainThread())
#endif
{
Expand All @@ -107,7 +107,7 @@ class RefCountedBase {

void applyRefDerefThreadingCheck() const
{
#if ASSERT_ENABLED
#if ASSERT_ENABLED && !PLATFORM(JAVA)
if (m_refCount == 1) {
// Likely an ownership transfer across threads that may be safe.
m_isOwnedByMainThread = isMainThread();
Expand Down