Init of Java 25 parser

[Laurens-W]

What's changed?

Initial setup of Java 25 parser based on the Java 21 variant

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[Laurens-W]

I think the rewrite-gradle-plugin can't handle Java 25 just yet, hence why it's spewing out so many diffs, there's a concurrency issue. I can reproduce it locally

[timtebeek]

There's a bit of a hack still in the Java 21 parser, which we wouldn't need there anymore following the new matching of Java versions with LTS parsers. Can we remove that handling from the Java 21 parser?

rewrite/rewrite-java-21/src/main/java/org/openrewrite/java/isolated/ReloadableJava21ParserVisitor.java

Lines 1791 to 1794 in 8ce5308

	// Java 21 and 23 have a different return type from getCommentTree; with reflection we can support both
	Method getCommentTreeMethod = DocCommentTable.class.getMethod("getCommentTree", JCTree.class);
	DocCommentTree commentTree = (DocCommentTree) getCommentTreeMethod.invoke(docCommentTable, t);
	@SuppressWarnings("unchecked") J2 j = (J2) scan(t, formatWithCommentTree(prefix, (JCTree) t, commentTree));

And I say that as the one that added it; ideally we push folks to the next LTS parser as opposed to back porting based on what folks happen to have on the classpath.

• Backport DocCommentTree reflection to ReloadableJava17ParserVisitor #4618

[timtebeek]

These lines are new as compared to the Java 21 parser; they look fine to me; figured call these out for wider review as the rest of the file is identical between 21 and 25.

[timtebeek]

Similarly to above, we can revert this ward that was added to the Java 21 parser to support Java 24:

rewrite/rewrite-java-21/src/main/java/org/openrewrite/java/isolated/ReloadableJava21TypeMapping.java

Lines 780 to 785 in 8ce5308

	/**
	* Check for the `UnknownType` which existed up until JDK 22; starting with JDK 23 only the `ErrorType` is used
	*/
	public static boolean isUnknownType(@Nullable Type type) {
	return type != null && type.getClass().getName().equals("com.sun.tools.javac.code.Type$UnknownType");
	}

We'd want to revert to the simple type instanceof Type.UnknownType check that we had before these two PRs:

• feat: support JDK24 #5309
• Simplify UnknownType check in Java 21 parser #5385

[timtebeek]

Wondering if we should temporarily disable this workflow completely, such that we can merge the Java 25 parser and aim to fix the runtime issues downstream that cause the excessive suggstions to be reported.

[Laurens-W]

That seems like the only way forward, it is gonna be a challenge though, since the rewrite-gradle-plugin doesn't seem immediately fit for Gradle 9, but I can continue looking into that one :)

[timtebeek]

Now seeing the same suspicious code suggestions in an unrelated PR, so perhaps we don't have to trouble shoot that here:

• RewriteTest should load recipes through RecipeLoader, not RecipeIntrospectionUtils #5983 (review)

[Laurens-W]

Now seeing the same suspicious code suggestions in an unrelated PR, so perhaps we don't have to trouble shoot that here:

• RewriteTest should load recipes through RecipeLoader, not RecipeIntrospectionUtils #5983 (review)

I was explicitly able to reproduce by changing my system jdk to 25 explicitly and running the plugin as we do in the pipeline though

[timtebeek]

Great to see, thanks for taking the time to remove some oddities from our older parsers, ensure going forward we pick the right next parser, and can now move on to making the other parts work for Java 25+.