[release-4.17] OCPBUGS-60211: Update service selector to match deployment label #406
Conversation
Changed the service's selector label to k8s-app=cloud-manager-operator to ensure it matches the deployment’s [template label](https://github.com/openshift/cluster-cloud-controller-manager-operator/blob/5fc7a51c0cd1955c8e450a11a58d65b4823aa6a5/manifests/0000_26_cloud-controller-manager-operator_11_deployment.yaml#L25). This enables the service to correctly discover the pod and creates an EndpointSlice for port 9258, which is necessary for proper documentation created by the communication matrix (see further explanation described in the opened [bug](https://issues.redhat.com/browse/OCPBUGS-53300))
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-60015 has been cloned as Jira Issue OCPBUGS-60211. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-60211, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: theobarberbany The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@theobarberbany: This pull request references Jira Issue OCPBUGS-60211, which is valid. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label backport-risk-assessed |
|
@theobarberbany: Can not set label backport-risk-assessed: Must be member in one of these teams: [] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Seems like @sunzhaohua2 will be on PTO for some time now. |
|
/label qe-approved launch cluster with #406 and #407 on gcp, the service selector changed to |
openshift-ci
bot
added
the
qe-approved
|
@JoelSpeed Expect your backport-risk-assessed label here. Thanks! |
|
/label backport-risk-assessed |
openshift-ci
bot
added
the
backport-risk-assessed
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit fbddd2c
into
openshift:release-4.17
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-60211: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-60211 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-cloud-controller-manager-operator |
|
/cherry-pick release-4.16 |
|
@shirmoran: new pull request created: #410 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is an automated cherry-pick of #403
/assign shirmoran