-
Notifications
You must be signed in to change notification settings - Fork 69
[release-4.16] OCPBUGS-60387: Update service selector to match deployment label #410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.16] OCPBUGS-60387: Update service selector to match deployment label #410
Conversation
Changed the service's selector label to k8s-app=cloud-manager-operator to ensure it matches the deployment’s [template label](https://github.com/openshift/cluster-cloud-controller-manager-operator/blob/5fc7a51c0cd1955c8e450a11a58d65b4823aa6a5/manifests/0000_26_cloud-controller-manager-operator_11_deployment.yaml#L25). This enables the service to correctly discover the pod and creates an EndpointSlice for port 9258, which is necessary for proper documentation created by the communication matrix (see further explanation described in the opened [bug](https://issues.redhat.com/browse/OCPBUGS-53300))
@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-60211 with correct target version. Will retitle the PR to link to the clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-60387, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/test unit |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cc @huali9 |
/test unit |
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/label qe-approved launch cluster with #410 on azure, the service selector changed to
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-60387, which is valid. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
35637e4
into
openshift:release-4.16
@openshift-cherrypick-robot: Jira Issue OCPBUGS-60387: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-60387 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-cloud-controller-manager-operator |
This is an automated cherry-pick of #406
/assign shirmoran