OCPBUGS-46422: Add a ValidatingAdmissionPolicy blocking ServiceCIDR changes [4.20]

[danwinship]

backport of #2797
note that this won't pass CI until openshift/kubernetes#2466 merges but it can still be lgtm'ed before then

[openshift-ci-robot]

@danwinship: This pull request references Jira Issue OCPBUGS-46422, which is invalid:

• expected the bug to target either version "4.21." or "openshift-4.21.", but it targets "4.20.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

backport of #2797
note that this won't pass CI until openshift/kubernetes#2466 merges but it can still be lgtm'ed before then

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@danwinship: This pull request references Jira Issue OCPBUGS-46422, which is valid.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.z) matches configured target version for branch (4.20.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-61196 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-61196 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0
• bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

backport of #2797
note that this won't pass CI until openshift/kubernetes#2466 merges but it can still be lgtm'ed before then

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[danwinship]

/label backport-risk-assessed
/assign @kyrtapz @bpickard22
this is the same as #2797 / #2605, just on release-4.20

[kyrtapz]

/lgtm

/hold
Feel free to remove the hold once the deps merge.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, kyrtapz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [danwinship,kyrtapz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[danwinship]

/hold cancel

[danwinship]

/retest

[danwinship]

/verified by "[sig-network] ServiceCIDR should be blocked"
to be added in openshift/origin#30434, manually tested in https://prow.ci.openshift.org/view/gs/test-platform-results/logs/release-openshift-origin-installer-launch-aws-modern/1990926565860446208

[openshift-ci-robot]

@danwinship: This PR has been marked as verified by "[sig-network] ServiceCIDR should be blocked".

In response to this:

/verified by "[sig-network] ServiceCIDR should be blocked"
to be added in openshift/origin#30434, manually tested in https://prow.ci.openshift.org/view/gs/test-platform-results/logs/release-openshift-origin-installer-launch-aws-modern/1990926565860446208

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[danwinship]

/retest-required

[danwinship]

/skip

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 1666a71 and 2 for PR HEAD a984a49 in total

[danwinship]

/retest-required

[danwinship]

/override ci/prow/e2e-aws-ovn-windows

[openshift-ci]

@danwinship: Overrode contexts on behalf of danwinship: ci/prow/e2e-aws-ovn-windows

In response to this:

/override ci/prow/e2e-aws-ovn-windows

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@danwinship: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/4.21-upgrade-from-stable-4.20-e2e-aws-ovn-upgrade	a984a49	link	false	/test 4.21-upgrade-from-stable-4.20-e2e-aws-ovn-upgrade
ci/prow/4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-upgrade	a984a49	link	false	/test 4.21-upgrade-from-stable-4.20-e2e-gcp-ovn-upgrade
ci/prow/4.21-upgrade-from-stable-4.20-e2e-azure-ovn-upgrade	a984a49	link	false	/test 4.21-upgrade-from-stable-4.20-e2e-azure-ovn-upgrade
ci/prow/4.20-upgrade-from-stable-4.19-e2e-azure-ovn-upgrade	a984a49	link	false	/test 4.20-upgrade-from-stable-4.19-e2e-azure-ovn-upgrade
ci/prow/4.20-upgrade-from-stable-4.19-e2e-aws-ovn-upgrade	a984a49	link	false	/test 4.20-upgrade-from-stable-4.19-e2e-aws-ovn-upgrade
ci/prow/4.20-upgrade-from-stable-4.19-e2e-gcp-ovn-upgrade	a984a49	link	false	/test 4.20-upgrade-from-stable-4.19-e2e-gcp-ovn-upgrade
ci/prow/security	a984a49	link	false	/test security
ci/prow/e2e-aws-ovn-windows	a984a49	link	true	/test e2e-aws-ovn-windows

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@danwinship: Jira Issue OCPBUGS-46422: Some pull requests linked via external trackers have merged:

• openshift/kubernetes#2382
• openshift/origin#30257
• openshift/cluster-network-operator#2827

The following pull request, linked via external tracker, has not merged:

• openshift/origin#30434 is open

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-46422 has not been moved to the MODIFIED state.

This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload.

In response to this:

backport of #2797
note that this won't pass CI until openshift/kubernetes#2466 merges but it can still be lgtm'ed before then

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-robot]

Fix included in accepted release 4.20.0-0.nightly-2025-11-22-184222