-
Notifications
You must be signed in to change notification settings - Fork 2.7k
[GPU] check the feature padding at onednn reorder #31783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GPU] check the feature padding at onednn reorder #31783
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug in the oneDNN reorder implementation where feature axis padding was not being properly checked, causing incorrect behavior when feature padding was present. The fix adds validation for feature axis padding in the is_supported_pad()
function to ensure oneDNN reorders fallback to OpenCL when feature padding is detected.
- Added feature axis padding validation to prevent oneDNN from handling unsupported padding scenarios
- Modified the return condition to include the new feature padding check alongside existing spatial and batch padding checks
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
bool no_feature_padding = true; | ||
no_feature_padding &= (pad._lower_size[1] == 0); | ||
no_feature_padding &= (pad._upper_size[1] == 0); | ||
|
||
return no_feature_padding; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bool no_feature_padding = true; | |
no_feature_padding &= (pad._lower_size[1] == 0); | |
no_feature_padding &= (pad._upper_size[1] == 0); | |
return no_feature_padding; | |
return (pad._lower_size[1] == 0) && (pad._upper_size[1] == 0); |
Can be refactored?
Description of the issue(symptom, root-cause, how it was resolved)
The code and line that caused this issue (if it is not changed directly)
Reproduction step and snapshot (if applicable. Do not attach for customer model)
Problematic graph
Checklist
Tickets: