-
Notifications
You must be signed in to change notification settings - Fork 2.7k
[GPU] check the feature padding at onednn reorder #31783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yeonbok
merged 3 commits into
openvinotoolkit:master
from
sungeunk:172242_cyberlink_onednn_reorder_pad
Aug 20, 2025
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -65,7 +65,7 @@ struct ReorderImplementationManager : public ImplementationManager { | |||||||||||||
return false; | ||||||||||||||
|
||||||||||||||
// onednn doesn't support paddings | ||||||||||||||
if (!is_supported_pad(input_layout) || !is_supported_pad(output_layout)) | ||||||||||||||
if (!is_supported_pad_for_reorder(input_layout) || !is_supported_pad_for_reorder(output_layout)) | ||||||||||||||
return false; | ||||||||||||||
|
||||||||||||||
// Native impl works faster for this type of reorder | ||||||||||||||
|
@@ -90,6 +90,20 @@ struct ReorderImplementationManager : public ImplementationManager { | |||||||||||||
|
||||||||||||||
return true; | ||||||||||||||
} | ||||||||||||||
|
||||||||||||||
static bool is_supported_pad_for_reorder(const layout& layout) { | ||||||||||||||
// check to support the batch/spatial pad for onednn. | ||||||||||||||
if (!is_supported_pad(layout)) | ||||||||||||||
return false; | ||||||||||||||
|
||||||||||||||
// Check feature pad | ||||||||||||||
const auto& pad = layout.data_padding; | ||||||||||||||
bool no_feature_padding = true; | ||||||||||||||
no_feature_padding &= (pad._lower_size[1] == 0); | ||||||||||||||
no_feature_padding &= (pad._upper_size[1] == 0); | ||||||||||||||
|
||||||||||||||
return no_feature_padding; | ||||||||||||||
Comment on lines
+101
to
+105
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Can be refactored? |
||||||||||||||
} | ||||||||||||||
}; | ||||||||||||||
|
||||||||||||||
} // namespace onednn | ||||||||||||||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.