Skip to content

Conversation

r3kste
Copy link
Collaborator

@r3kste r3kste commented Sep 10, 2025

This PR refactors params_plot() to use the backend plotting module, closely following the changes made in #599 and #600.

Summary of Changes

  1. Separated logic for data extraction and plotting.
  2. Added backend and palette arguments.

Copy link

codecov bot commented Sep 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/optimagic/visualization/backends.py 100.00% <100.00%> (ø)
src/optimagic/visualization/history_plots.py 95.78% <100.00%> (+2.44%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@r3kste
Copy link
Collaborator Author

r3kste commented Sep 10, 2025

Ping @timmens for review.

@timmens timmens self-requested a review September 10, 2025 16:27
Copy link
Member

@timmens timmens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thank you!

I only have two minor remarks, and additionally the question regarding the default templates that was raised on Zulip.

Refactor multiple results retrieval function.
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@r3kste r3kste force-pushed the params_plot_refactor branch from 0641069 to 074813e Compare September 23, 2025 12:54
@timmens timmens merged commit b029d2c into optimagic-dev:main Sep 23, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants