Skip to content

[POC][tests-only] e2e tests with Playwright only #12941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2025
Merged

[POC][tests-only] e2e tests with Playwright only #12941

merged 1 commit into from
Sep 19, 2025

Conversation

Ashim-Stha
Copy link
Contributor

@Ashim-Stha Ashim-Stha commented Aug 20, 2025 •
edited
Loading

Description

Rewrite the old Cucumber test from tests/e2e/cucumber/features/shares/internalLink.feature with a new Playwright test at tests/spec/internalLink.spec.ts

Related Issue

#12938

Run test

To run test locally in chromium in headed mode

pnpm test:e2e:playwright --project=chromium --headed

@Ashim-Stha Ashim-Stha self-assigned this Aug 20, 2025
@CLAassistant
Copy link

CLAassistant commented Aug 20, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Ashim-Stha Ashim-Stha force-pushed the replaceCucumberWithPlaywright branch 14 times, most recently from 1facfa0 to 9b2c634 Compare August 25, 2025 10:46
@Ashim-Stha Ashim-Stha marked this pull request as ready for review August 25, 2025 10:56
@saw-jan
Copy link
Member

saw-jan commented Aug 25, 2025

@Ashim-Stha Could you edit the PR title to something like this?
[POC][tests-only] e2e tests with Playwright only

@Ashim-Stha Ashim-Stha changed the title [tests-only][full-ci] Replace cucumber with playwright [POC][tests-only] e2e tests with Playwright only Aug 25, 2025
@Ashim-Stha
Copy link
Contributor Author

@Ashim-Stha Could you edit the PR title to something like this? [POC][tests-only] e2e tests with Playwright only

done 👍

nabim777
nabim777 reviewed Aug 25, 2025
View reviewed changes
@Ashim-Stha Ashim-Stha force-pushed the replaceCucumberWithPlaywright branch from 9b2c634 to c242bfc Compare August 25, 2025 11:43
@Ashim-Stha Ashim-Stha force-pushed the replaceCucumberWithPlaywright branch 2 times, most recently from f52c40f to 751f68f Compare September 11, 2025 05:44
@Ashim-Stha Ashim-Stha requested a review from saw-jan September 11, 2025 05:45
saw-jan
saw-jan reviewed Sep 12, 2025
View reviewed changes
saw-jan
saw-jan reviewed Sep 12, 2025
View reviewed changes
@saw-jan saw-jan requested a review from LukasHirt September 12, 2025 04:03
@saw-jan
Copy link
Member

saw-jan commented Sep 12, 2025

@LukasHirt Could you review this one and check if this is how we want to have the tests?

@Ashim-Stha Ashim-Stha force-pushed the replaceCucumberWithPlaywright branch 8 times, most recently from 136e5fb to edc5302 Compare September 12, 2025 06:29
@Ashim-Stha Ashim-Stha requested a review from saw-jan September 12, 2025 06:45
phil-davis
phil-davis reviewed Sep 15, 2025
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few comments related to readability of the test "scenario".

What sort of people do we want to be able to read and comprehend what the test suite is testing?
Do we want non-technical people to be able to put together a test scenario (using existing available steps) that would demonstrate some expected behavior?
Or is the test suite to be used just by technical staff who are doing SW development and test development?

Answers to these questions might help answer what format/framework is best for implementing the test suite.

tests/e2e-playwright/specs/internalLink.spec.ts Outdated
)
await ui.LogOutUser(actorsEnvironment, 'Alice')

expect(await ui.isAbleToEditFileOrFolder(actorsEnvironment, 'Brian', 'myfolder')).toBeFalsy()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implements the scenario step:

    Then "Brian" should not be able to edit folder "myfolder"

A technical user who knows coding can read the line of code and work out what is being expected. So the choice of format depends who the "target audience" is for the test suite.

LukasHirt
LukasHirt approved these changes Sep 15, 2025
View reviewed changes
Copy link
Collaborator

@LukasHirt LukasHirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Ashim-Stha Ashim-Stha force-pushed the replaceCucumberWithPlaywright branch from edc5302 to f935551 Compare September 16, 2025 09:13
@Ashim-Stha Ashim-Stha force-pushed the replaceCucumberWithPlaywright branch from f935551 to 971cce6 Compare September 16, 2025 09:14
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@nirajacharya2 nirajacharya2 linked an issue Sep 16, 2025 that may be closed by this pull request
[QA] replace cucumber with playwright #12938
Closed
@nirajacharya2 nirajacharya2 mentioned this pull request Sep 16, 2025
Open
54 tasks
@saw-jan
Copy link
Member

saw-jan commented Sep 18, 2025

@LukasHirt @deyankiteworks Please feel free to merge this if everything is ok from your side

@deyankiteworks deyankiteworks merged commit 62c4b96 into master Sep 19, 2025
4 checks passed
@deyankiteworks deyankiteworks deleted the replaceCucumberWithPlaywright branch September 19, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasHirt LukasHirt LukasHirt approved these changes

@deyankiteworks deyankiteworks deyankiteworks approved these changes

@anon-pradip anon-pradip Awaiting requested review from anon-pradip

@prashant-gurung899 prashant-gurung899 Awaiting requested review from prashant-gurung899

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@nabim777 nabim777 Awaiting requested review from nabim777

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

@saw-jan saw-jan Awaiting requested review from saw-jan

@phil-davis phil-davis Awaiting requested review from phil-davis

Assignees

@Ashim-Stha Ashim-Stha

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[QA] replace cucumber with playwright
8 participants
@Ashim-Stha @CLAassistant @saw-jan @phil-davis @LukasHirt @nabim777 @nirajacharya2 @deyankiteworks