Add support of Mercure running on a subdomain #1394
Conversation
|
I replaced the |
Co-authored-by: Martin Eiber <[email protected]>
|
| $tokenProvider: '@Pimcore\Bundle\StudioBackendBundle\Mercure\Service\ClientTokenService' | ||
| $cookieLifetime: '%pimcore_studio_backend.mercure_settings.cookie_lifetime%' | ||
| $cookieSameSite: '%pimcore_studio_backend.mercure_settings.cookie_same_site%' | ||
| $jwt_cookie_strictness: '%pimcore_studio_backend.mercure_settings.jwt_cookie_strictness%' |
There was a problem hiding this comment.
| $jwt_cookie_strictness: '%pimcore_studio_backend.mercure_settings.jwt_cookie_strictness%' | |
| $jwtCookieStrictness: '%pimcore_studio_backend.mercure_settings.jwt_cookie_strictness%' |
to keep camelCase as the others
There was a problem hiding this comment.
maybe even just $cookieStrictness, it's always JWT in this context
| ->info('Domain where to set the Mercure auth cookie, e.g. ".example.com".') | ||
| ->defaultNull() | ||
| ->end() | ||
| ->booleanNode('jwt_cookie_strictness') |
There was a problem hiding this comment.
maybe as booleanNode might be not good if we have to consider SAMESITE_LAX use case too, might need a followup for https://github.com/pimcore/direct-edit/pull/85 in case
| private UrlServiceInterface $urlService, | ||
| private int $cookieLifetime = 3600, | ||
| private string $cookieSameSite = Cookie::SAMESITE_STRICT, | ||
| private bool $jwt_cookie_strictness = true, |
There was a problem hiding this comment.
| private bool $jwt_cookie_strictness = true, | |
| private bool $jwtCookieStrictness = true, |
| true, | ||
| false, | ||
| $this->cookieSameSite | ||
| $this->jwt_cookie_strictness ? Cookie::SAMESITE_STRICT : Cookie::SAMESITE_NONE |
There was a problem hiding this comment.
| $this->jwt_cookie_strictness ? Cookie::SAMESITE_STRICT : Cookie::SAMESITE_NONE | |
| $this->jwtCookieStrictness ? Cookie::SAMESITE_STRICT : Cookie::SAMESITE_NONE |
3 participants
On Pimcore PaaS, we'd like to switch from running Mercure in a side app to running Mercure as a Service.
But running Mercure as a Service implies that we run it on a subdomain.
Those modifications are required for the authentication layer.
There are also changes required in studio-ui-bundle, see pimcore/studio-ui-bundle#2095.