Skip to content

Conversation

@vrobert78
Copy link
Contributor

On Pimcore PaaS, we'd like to switch from running Mercure in a side app to running Mercure as a Service.
But running Mercure as a Service implies that we run it on a subdomain.
Those modifications are required for the authentication layer.

There are also changes required in studio-backend-bundle, see pimcore/studio-backend-bundle#1394.

@vrobert78
Copy link
Contributor Author

Regarding the quality gate, I haven't changed the code as it's not mine.
But it should be easy by just changing:

this.topics.forEach(topic => {
  url.searchParams.append('topic', topic)
})

by

for (const topic of this.topics) {
  url.searchParams.append('topic', topic)
}

@sonarqubecloud
Copy link

@markus-moser
Copy link
Contributor

@vrobert78 Thanks a lot for your PR, added the same to a second relevant location (484c83b). I accepted the quality gate case for now as it is really a minor topic. ;)

Will merge it, thanks again!

@markus-moser markus-moser merged commit 2c80b77 into pimcore:1.x Sep 23, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Sep 23, 2025
@markus-moser markus-moser added this to the next milestone Sep 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants