refactor: Prepare for Velox replacing folly::Optional with std::optional #25789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: It follows style guide and also avoids extra "velox depends on folly". https://github.com/facebookincubator/velox/blob/09bc52ac56a4876385686cd26e6891fd7c2ca871/CODING_STYLE.md#L323-L324 X-link: facebookincubator/velox#14455 Differential Revision: D80160509 Pulled By: mbasmanova
Collaborator
|
This pull request was exported from Phabricator. Differential Revision: D80160509 |
mbasmanova
changed the title
mbasmanova
changed the title
facebook-github-bot
pushed a commit
to facebookincubator/velox
that referenced
this pull request
Aug 14, 2025
Summary: X-link: prestodb/presto#25789 It follows style guide and also avoids extra "velox depends on folly". https://github.com/facebookincubator/velox/blob/09bc52ac56a4876385686cd26e6891fd7c2ca871/CODING_STYLE.md#L323-L324 Pull Request resolved: #14455 Reviewed By: Yuhta Differential Revision: D80160509 Pulled By: mbasmanova fbshipit-source-id: 208aad9a7c230b705343d3f7acb4fd89e38fde1d
wypb
pushed a commit
to wypb/velox
that referenced
this pull request
Sep 3, 2025
…or#14455) Summary: X-link: prestodb/presto#25789 It follows style guide and also avoids extra "velox depends on folly". https://github.com/facebookincubator/velox/blob/09bc52ac56a4876385686cd26e6891fd7c2ca871/CODING_STYLE.md#L323-L324 Pull Request resolved: facebookincubator#14455 Reviewed By: Yuhta Differential Revision: D80160509 Pulled By: mbasmanova fbshipit-source-id: 208aad9a7c230b705343d3f7acb4fd89e38fde1d
lga-zurich
pushed a commit
to lga-zurich/velox-exchange
that referenced
this pull request
Sep 8, 2025
…or#14455) Summary: X-link: prestodb/presto#25789 It follows style guide and also avoids extra "velox depends on folly". https://github.com/facebookincubator/velox/blob/09bc52ac56a4876385686cd26e6891fd7c2ca871/CODING_STYLE.md#L323-L324 Pull Request resolved: facebookincubator#14455 Reviewed By: Yuhta Differential Revision: D80160509 Pulled By: mbasmanova fbshipit-source-id: 208aad9a7c230b705343d3f7acb4fd89e38fde1d
lga-zurich
pushed a commit
to lga-zurich/velox-exchange
that referenced
this pull request
Sep 8, 2025
…or#14455) Summary: X-link: prestodb/presto#25789 It follows style guide and also avoids extra "velox depends on folly". https://github.com/facebookincubator/velox/blob/09bc52ac56a4876385686cd26e6891fd7c2ca871/CODING_STYLE.md#L323-L324 Pull Request resolved: facebookincubator#14455 Reviewed By: Yuhta Differential Revision: D80160509 Pulled By: mbasmanova fbshipit-source-id: 208aad9a7c230b705343d3f7acb4fd89e38fde1d
lga-zurich
pushed a commit
to lga-zurich/velox-exchange
that referenced
this pull request
Sep 8, 2025
…or#14455) Summary: X-link: prestodb/presto#25789 It follows style guide and also avoids extra "velox depends on folly". https://github.com/facebookincubator/velox/blob/09bc52ac56a4876385686cd26e6891fd7c2ca871/CODING_STYLE.md#L323-L324 Pull Request resolved: facebookincubator#14455 Reviewed By: Yuhta Differential Revision: D80160509 Pulled By: mbasmanova fbshipit-source-id: 208aad9a7c230b705343d3f7acb4fd89e38fde1d
lga-zurich
pushed a commit
to lga-zurich/velox-exchange
that referenced
this pull request
Sep 8, 2025
…or#14455) Summary: X-link: prestodb/presto#25789 It follows style guide and also avoids extra "velox depends on folly". https://github.com/facebookincubator/velox/blob/09bc52ac56a4876385686cd26e6891fd7c2ca871/CODING_STYLE.md#L323-L324 Pull Request resolved: facebookincubator#14455 Reviewed By: Yuhta Differential Revision: D80160509 Pulled By: mbasmanova fbshipit-source-id: 208aad9a7c230b705343d3f7acb4fd89e38fde1d
lga-zurich
pushed a commit
to lga-zurich/velox-exchange
that referenced
this pull request
Sep 8, 2025
…or#14455) Summary: X-link: prestodb/presto#25789 It follows style guide and also avoids extra "velox depends on folly". https://github.com/facebookincubator/velox/blob/09bc52ac56a4876385686cd26e6891fd7c2ca871/CODING_STYLE.md#L323-L324 Pull Request resolved: facebookincubator#14455 Reviewed By: Yuhta Differential Revision: D80160509 Pulled By: mbasmanova fbshipit-source-id: 208aad9a7c230b705343d3f7acb4fd89e38fde1d
lga-zurich
pushed a commit
to lga-zurich/velox-exchange
that referenced
this pull request
Sep 8, 2025
…or#14455) Summary: X-link: prestodb/presto#25789 It follows style guide and also avoids extra "velox depends on folly". https://github.com/facebookincubator/velox/blob/09bc52ac56a4876385686cd26e6891fd7c2ca871/CODING_STYLE.md#L323-L324 Pull Request resolved: facebookincubator#14455 Reviewed By: Yuhta Differential Revision: D80160509 Pulled By: mbasmanova fbshipit-source-id: 208aad9a7c230b705343d3f7acb4fd89e38fde1d
lga-zurich
pushed a commit
to lga-zurich/velox-exchange
that referenced
this pull request
Sep 8, 2025
…or#14455) Summary: X-link: prestodb/presto#25789 It follows style guide and also avoids extra "velox depends on folly". https://github.com/facebookincubator/velox/blob/09bc52ac56a4876385686cd26e6891fd7c2ca871/CODING_STYLE.md#L323-L324 Pull Request resolved: facebookincubator#14455 Reviewed By: Yuhta Differential Revision: D80160509 Pulled By: mbasmanova fbshipit-source-id: 208aad9a7c230b705343d3f7acb4fd89e38fde1d
lga-zurich
pushed a commit
to lga-zurich/velox-exchange
that referenced
this pull request
Sep 8, 2025
…or#14455) Summary: X-link: prestodb/presto#25789 It follows style guide and also avoids extra "velox depends on folly". https://github.com/facebookincubator/velox/blob/09bc52ac56a4876385686cd26e6891fd7c2ca871/CODING_STYLE.md#L323-L324 Pull Request resolved: facebookincubator#14455 Reviewed By: Yuhta Differential Revision: D80160509 Pulled By: mbasmanova fbshipit-source-id: 208aad9a7c230b705343d3f7acb4fd89e38fde1d
lga-zurich
pushed a commit
to lga-zurich/velox-exchange
that referenced
this pull request
Sep 8, 2025
…or#14455) Summary: X-link: prestodb/presto#25789 It follows style guide and also avoids extra "velox depends on folly". https://github.com/facebookincubator/velox/blob/09bc52ac56a4876385686cd26e6891fd7c2ca871/CODING_STYLE.md#L323-L324 Pull Request resolved: facebookincubator#14455 Reviewed By: Yuhta Differential Revision: D80160509 Pulled By: mbasmanova fbshipit-source-id: 208aad9a7c230b705343d3f7acb4fd89e38fde1d
lga-zurich
pushed a commit
to lga-zurich/velox-exchange
that referenced
this pull request
Sep 8, 2025
…or#14455) Summary: X-link: prestodb/presto#25789 It follows style guide and also avoids extra "velox depends on folly". https://github.com/facebookincubator/velox/blob/09bc52ac56a4876385686cd26e6891fd7c2ca871/CODING_STYLE.md#L323-L324 Pull Request resolved: facebookincubator#14455 Reviewed By: Yuhta Differential Revision: D80160509 Pulled By: mbasmanova fbshipit-source-id: 208aad9a7c230b705343d3f7acb4fd89e38fde1d
lga-zurich
pushed a commit
to lga-zurich/velox-exchange
that referenced
this pull request
Sep 8, 2025
…or#14455) Summary: X-link: prestodb/presto#25789 It follows style guide and also avoids extra "velox depends on folly". https://github.com/facebookincubator/velox/blob/09bc52ac56a4876385686cd26e6891fd7c2ca871/CODING_STYLE.md#L323-L324 Pull Request resolved: facebookincubator#14455 Reviewed By: Yuhta Differential Revision: D80160509 Pulled By: mbasmanova fbshipit-source-id: 208aad9a7c230b705343d3f7acb4fd89e38fde1d
mbasmanova
commented
Nov 4, 2025
Contributor
Author
mbasmanova
left a comment
mbasmanova
left a comment
There was a problem hiding this comment.
Thanks. For some reason "Approve" option is not available. CC: @amitkdutta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
== NO RELEASE NOTE ==
Summary:
It follows style guide and also avoids extra "velox depends on folly".
https://github.com/facebookincubator/velox/blob/09bc52ac56a4876385686cd26e6891fd7c2ca871/CODING_STYLE.md#L323-L324
X-link: facebookincubator/velox#14455
Differential Revision: D80160509
Pulled By: mbasmanova