ci!: drop Node 14/16 support #761
Conversation
Node 14 and 16 are incompatible with prettier-plugin-jsdoc-type. This commit removes them from the CI matrix and updates package.json to enforce Node >=18.18.0 and [email protected].
|
WalkthroughRemoved Node 14/16 ESLint matrix combos from CI, renamed the ESLint install step label, replaced the “Perf” step with a universal “Lint” step, and kept other CI steps unchanged. Updated engines.node to >=18.18.0 and packageManager to [email protected]. Added two NUL characters to README.md after the License section. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Dev as Push/PR
participant CI as GitHub Actions
participant Node as Node Setup
participant PNPM as pnpm
participant Tests as Test Runner
Dev->>CI: Trigger workflow
CI->>Node: Setup Node (>=18.18.0 matrix only)
CI->>PNPM: Install deps
CI->>PNPM: Install ESLint (version from matrix.eslint)
Note over CI,PNPM: Step label now references matrix.eslint
CI->>PNPM: Lint (pnpm lint)
Note over CI,PNPM: Replaces prior "Perf" step
CI->>Tests: Run tests
CI-->>Dev: Report results
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Pre-merge checks (3 passed)✅ Passed checks (3 passed)
Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (2)
.github/workflows/ci.yml (2)
27-31: Drop commented matrix entries or justify with a noteCommented Node 14/16 include block is dead weight now that engines >=18.18.0. Either remove it or add a brief comment explaining historical context.
- # include: - # - node: 16 - # eslint: 8 - # - node: 14 - # eslint: 8 + # Older Node versions (14/16) are no longer supported (see package.json engines).
49-51: Nit: step label uses node instead of eslint versionThe step name says “Install ESLint ${{ matrix.node }}” but it installs ESLint ${{ matrix.eslint }}. Rename for clarity.
- - name: Install ESLint ${{ matrix.node }} + - name: Install ESLint ${{ matrix.eslint }} if: ${{ matrix.eslint != 9 }} run: pnpm install -D eslint@${{ matrix.eslint }} @graphql-eslint/eslint-plugin@3 eslint-plugin-svelte@2 svelte@3 vue-eslint-parser@9
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to c1005fc in 1 minute and 30 seconds. Click for details.
- Reviewed
48lines of code in2files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/ci.yml:27
- Draft comment:
Remove commented-out code (both the 'include' matrix and 'Perf' step) if Node 14/16 support is permanently dropped. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% The comment suggests removing commented code IF Node 14/16 support is dropped. However, looking at the active Node versions (18,20,22), it appears Node 14/16 support HAS been dropped. The commented code is now just noise. The comment is speculative ("if") rather than definitive, and the condition it specifies has already been met. The code could be commented out temporarily for testing or future reference. Maybe Node 14/16 support isn't permanently dropped but just temporarily disabled. The presence of only newer Node versions (18+) in the active matrix strongly suggests this is a permanent change. Keeping commented code creates maintenance debt. Delete this comment. The condition it specifies has already been met, and it's asking for verification rather than pointing out a clear issue.
2. package.json:15
- Draft comment:
Engine version is set to '>=18.0.0' but the PR description intends Node >=18.18.0. Update the engines field accordingly. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% The comment references the PR description which we don't have access to. Without seeing the PR description, we can't verify if this suggestion is correct. This falls under the rule of needing strong evidence - we can't be sure this comment is correct without seeing the PR description. Additionally, this relates to dependency/version requirements which we're supposed to ignore. The comment might be correct if we had access to the PR description. The author might have explicitly stated they want to target Node 18.18.0. Even if the PR description does mention Node 18.18.0, our rules explicitly state we should not comment on dependency changes or assume anything about PR descriptions. We should delete this comment as it relates to dependency versioning (which we're told to ignore) and relies on PR description context we don't have.
Workflow ID: wflow_4P9wJJNfajGUtkRW
You can customize 
gemy26
force-pushed
the
drop-node14-16
branch
from
d52d928 to
23639ad
Compare
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Remove accidental NUL bytes from README (breaks rendering and can mark file as binary).
Two null characters slipped in after the License section. Delete these lines and ensure the file ends with a single newline.
Apply this diff:
-�
-�Verify no other NULs remain:
🏁 Script executed:
#!/bin/bash
# Find NUL bytes in README (treat file as text)
rg -nUa '\x00' README.md || echo "No NUL bytes found."Length of output: 11
Remove two NUL bytes from README.md (lines 201–202).
Delete these null characters to restore proper rendering:
- �
- �Then verify no NULs remain:
rg -nUa '\x00' README.md || echo "No NUL bytes found."🤖 Prompt for AI Agents
In README.md around lines 201–202, there are two NUL (0x00) characters that
break rendering; remove those two null bytes from the file (delete the
characters at those positions) and save the file, then run a binary-aware search
(for example, using ripgrep or another tool that can search for NULs) across
README.md to confirm no NUL bytes remain.
Summary
Drop Node 14 and 16 from CI and enforce Node >=18.18.0.
Why
prettier-plugin-jsdoc-typeand ESLint 9+ rely on modern syntax (??=) that isn’t available in Node <18.Changes
.github/workflows/ci.ymlto test only on Node 18, 20, and 22.package.json:"engines": { "node": ">=18.18.0" }Verification
pnpm lint,pnpm prettier --check ., andpnpm testlocally — all passed.Impact
Summary by CodeRabbit
Chores
Documentation
Important
Drop Node 14/16 support in CI and enforce Node >=18.0.0 in
package.json..github/workflows/ci.ymlto remove Node 14 and 16 from the test matrix.package.jsonto enforce Node version>=18.0.0.This description was created by
for c1005fc. You can customize this summary. It will automatically update as commits are pushed.