Skip to content

ci!: drop Node 14/16 support #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

ci!: drop Node 14/16 support #761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c1005fc
ci!: drop Node 14/16 support
gemy26 Sep 9, 2025
5542e9a
fix: update engines to >=18.18.0 and CI
gemy26 Sep 9, 2025
23639ad
fix: update pnpm to 8.15.6 for CI compatibility
gemy26 Sep 9, 2025
0c6c9da
chore: trigger bot re-review
gemy26 Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,6 @@ jobs:
eslint:
- 9
- 8
include:
- node: 16
eslint: 8
- node: 14
eslint: 8

steps:
- name: Checkout Repo
Expand All @@ -46,15 +41,12 @@ jobs:
- name: Install
run: pnpm install --prefer-frozen-lockfile

- name: Install ESLint ${{ matrix.node }}
- name: Install ESLint ${{ matrix.eslint }}
if: ${{ matrix.eslint != 9 }}
run: pnpm install -D eslint@${{ matrix.eslint }} @graphql-eslint/eslint-plugin@3 eslint-plugin-svelte@2 svelte@3 vue-eslint-parser@9

- name: Test
run: pnpm mocha

- name: Perf
# Skip on node 14, as eslint-plugin-n contains syntax that doesn't work
# with node 14
if: ${{ matrix.node != 14 }}
run: TIMING=1 pnpm lint
- name: Lint
run: pnpm lint
3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,3 +197,6 @@ Detailed changes for each release are documented in [CHANGELOG.md](./CHANGELOG.m
## License

[MIT](http://opensource.org/licenses/MIT)

Comment on lines +201 to +202
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Remove accidental NUL bytes from README (breaks rendering and can mark file as binary).

Two null characters slipped in after the License section. Delete these lines and ensure the file ends with a single newline.

Apply this diff:

-�
-�

Verify no other NULs remain:

🏁 Script executed:

#!/bin/bash
# Find NUL bytes in README (treat file as text)
rg -nUa '\x00' README.md || echo "No NUL bytes found."

Length of output: 11

Remove two NUL bytes from README.md (lines 201–202).

Delete these null characters to restore proper rendering:

- �
- �

Then verify no NULs remain:

rg -nUa '\x00' README.md || echo "No NUL bytes found."
🤖 Prompt for AI Agents 
In README.md around lines 201–202, there are two NUL (0x00) characters that
break rendering; remove those two null bytes from the file (delete the
characters at those positions) and save the file, then run a binary-aware search
(for example, using ripgrep or another tool that can search for NULs) across
README.md to confirm no NUL bytes remain.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@
],
"funding": "https://opencollective.com/eslint-plugin-prettier",
"license": "MIT",
"packageManager": "pnpm@7.33.5",
"packageManager": "pnpm@8.15.6",
"engines": {
"node": "^14.18.0 || >=16.0.0"
"node": ">=18.18.0"
},
"main": "eslint-plugin-prettier.js",
"types": "eslint-plugin-prettier.d.ts",
Expand Down