Fix FIFO delay parameter propagation in HCI #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
EXPFIFO
parameter inhci_interconnect
would introduce multicycle delays in ther_valid
signal, but thehci_core_r_id_filter
module would trigger incorrect assertions even whenMULTICYCLE_SUPPORT
was active. This created an inconsistency between modules where one parameter was changing what another module should check, without proper parameter propagation.Proposed Solution:
EXPFIFO
withFD
(FIFO Depth) parameter: integrated FIFO depth information directly into the HCI package structures for better parameter propagation.FD
parameter tohci_size_parameter_t
struct and created helper macros for consistent parameter handling.FD
parameter to allhci_core_intf
declarations throughout the system.FD
parameter checks for module port interfaces.These changes are reflected in Neureka's interface: pulp-platform/neureka#36 (comment)