-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add builtin_tools
to Agent
#2102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Marcelo Trylesinski <[email protected]>
…dantic#1752) Co-authored-by: Marcelo Trylesinski <[email protected]>
- Added builtin_tools field to ModelRequestParameters - Merged new output_mode and output_object fields from main - Updated test snapshots to include all fields - Resolved import conflicts to include both builtin tools and profiles
@@ -19,3 +19,4 @@ node_modules/ | |||
**.idea/ | |||
.coverage* | |||
/test_tmp/ | |||
.mcp.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For curiosity, why MCP servers did you use here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Groq is broken now. 😢
I'm not sure why the VCR test is passing... But this doesn't work anymore.
The only one that returns |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We just need to clarify Groq. I've added a lot of tests.
if isinstance(tool, WebSearchTool): | ||
# Groq uses the web_search tool similar to Anthropic | ||
# Based on https://console.groq.com/docs/agentic-tooling | ||
web_search_tool: chat.ChatCompletionToolParam = { | ||
'type': 'function', | ||
'function': { | ||
'name': 'web_search', | ||
'description': 'Search the web for information', | ||
'parameters': {'type': 'object', 'properties': {}, 'required': []}, | ||
}, | ||
} | ||
tools.append(web_search_tool) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did you see this being passed?
I don't think we need to pass anything to Groq. If using compoung-beta models, it will use it.
""" | ||
|
||
city: str | ||
country: str |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check doesn't seem necessary. It seems it works fine with 3 characters.
PR Change SummaryAdded
Added Files
How can I customize these reviews?Check out the Hyperlint AI Reviewer docs for more information on how to customize the review. If you just want to ignore it on this PR, you can add the Note specifically for link checks, we only check the first 30 links in a file and we cache the results for several hours (for instance, if you just added a page, you might experience this). Our recommendation is to add |
Fixes test and merge conflicts for #1722
Closes #840