anthropic: drop new lines on empty system prompt #2208
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Preview
|
DouweM
requested changes
Jul 23, 2025
Comment on lines
366
to
+368
| system_prompt = '\n\n'.join(system_prompt_parts) | ||
| if instructions := self._get_instructions(messages): | ||
| system_prompt = f'{instructions}\n\n{system_prompt}' | ||
| system_prompt = f'{instructions}\n\n{system_prompt}' if system_prompt else instructions |
There was a problem hiding this comment.
Suggested change
| system_prompt = '\n\n'.join(system_prompt_parts) | |
| if instructions := self._get_instructions(messages): | |
| system_prompt = f'{instructions}\n\n{system_prompt}' | |
| system_prompt = f'{instructions}\n\n{system_prompt}' if system_prompt else instructions | |
| if instructions := self._get_instructions(messages): | |
| system_prompt_parts.insert(0, instructions) | |
| system_prompt = '\n\n'.join(system_prompt_parts) |
There was a problem hiding this comment.
The suggestion is rendered incorrectly with the duplicate system_prompt = f'{instructions}\n\n{system_prompt}' line, but you get the point
|
@Kludex Could you add to this commit dropping older deprecated models of |
|
@medaminezghal That's completely unrelated so it should be done in a separate PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.