Skip to content

anthropic: drop new lines on empty system prompt #2208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

anthropic: drop new lines on empty system prompt #2208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pydantic_ai_slim/pydantic_ai/models/anthropic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ async def _map_message(self, messages: list[ModelMessage]) -> tuple[str, list[Be
assert_never(m)
system_prompt = '\n\n'.join(system_prompt_parts)
if instructions := self._get_instructions(messages):
system_prompt = f'{instructions}\n\n{system_prompt}'
system_prompt = f'{instructions}\n\n{system_prompt}' if system_prompt else instructions
Comment on lines 366 to +368
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
system_prompt = '\n\n'.join(system_prompt_parts)
if instructions := self._get_instructions(messages):
system_prompt = f'{instructions}\n\n{system_prompt}'
system_prompt = f'{instructions}\n\n{system_prompt}' if system_prompt else instructions
if instructions := self._get_instructions(messages):
system_prompt_parts.insert(0, instructions)
system_prompt = '\n\n'.join(system_prompt_parts)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The suggestion is rendered incorrectly with the duplicate system_prompt = f'{instructions}\n\n{system_prompt}' line, but you get the point

return system_prompt, anthropic_messages

@staticmethod
Expand Down