-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Handle built-in tool errors better in tool registration #2252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
DouweM
merged 23 commits into
pydantic:main
from
fswair:handle_builtin_tool_issues_on_registry
Jul 23, 2025
Merged
Handle built-in tool errors better in tool registration #2252
DouweM
merged 23 commits into
pydantic:main
from
fswair:handle_builtin_tool_issues_on_registry
Jul 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle errors better in tool registry
Tests: import pytest
def test_builtin_tool_registry():
"""
Test that built-in functions can be registered as tools.
"""
from pydantic_ai import Agent, Tool
from pydantic_ai.exceptions import UserError
from pydantic_ai.models.test import TestModel
with pytest.raises(UserError):
Agent(TestModel(), tools=[max])
with pytest.raises(UserError):
agent = Agent(TestModel())
agent.tool_plain(min)
agent = Agent(TestModel(), tools=[print])
assert 'print' in agent._function_toolset.tools
agent._function_toolset.tools.pop('print', None)
agent._function_toolset.add_tool(Tool(print))
assert 'print' in agent._function_toolset.tools |
@fswair Thank you! Can you please add some tests? |
DouweM
requested changes
Jul 22, 2025
@DouweM im so tired with this checks |
can u check again? @DouweM |
DouweM
requested changes
Jul 22, 2025
Co-authored-by: Douwe Maan <[email protected]>
DouweM
requested changes
Jul 22, 2025
@fswair Thanks Mert! |
Welcome 🔥🚀 |
KRRT7
pushed a commit
to aseembits93/pydantic-ai
that referenced
this pull request
Jul 24, 2025
Co-authored-by: Douwe Maan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The built-in errors comes from _function_schema origin, related lines, 100, 238, 245.
The issue is basically comes from built-in functions. If we can register a built-in function as a tool, it raise errors.