-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Handle built-in tool errors better in tool registration #2252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
DouweM
merged 23 commits into
pydantic:main
from
fswair:handle_builtin_tool_issues_on_registry
Jul 23, 2025
Merged
Changes from 19 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
94b11a9
fix: handle built-in tool errors in tool registry
fswair 7df60da
Merge branch 'pydantic:main' into handle_builtin_tool_issues_on_registry
fswair d2337cd
Merge branch 'pydantic:main' into handle_builtin_tool_issues_on_registry
fswair 4b72fba
Update _function_schema.py
fswair ac8da21
add builtin tool tests
fswair bc9686e
improve tests
fswair f677f05
add tests for missing annotations
fswair 840791e
fix tests
fswair b3d9def
add test tool signature
fswair a73b7e6
ignore pyright
fswair 6b4f54e
fix lint
fswair a38febb
fix lint
fswair 018df04
add no cover
fswair 8afe412
move imports to top
fswair 32d6a4f
add: pytest match for error message
fswair 25f011a
add: pytest match for ValueError
fswair e2a3803
Update tests/test_tools.py
fswair d79c047
remove not needed test
fswair 5bdb3dc
add: pytest absolute matches
fswair 00fef32
add: detailed pytest error messages
fswair 3b75b91
fix error message
fswair 7dd31b0
update error message
fswair 3d7d354
no cover
fswair File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.