-
Notifications
You must be signed in to change notification settings - Fork 310
mx: expose scaling calculation methods in training UX #2620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2620
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 29354b7 with merge base d05e54f ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
vkuzo
added a commit
that referenced
this pull request
Jul 28, 2025
Summary: Test Plan: performance on individual cast ```bash (pytorch_nightly) [[email protected] ~/local/ao (20250728_mx_expose_scale)]$ python benchmarks/mx_formats/cast_bench.py --mode dim0_mx_floor M 16384 K 16384 BLOCK_SIZE 32 GPU: NVIDIA B200 torch version: 2.9.0.dev20250724+cu128 triton version: 3.4.0 mode: dim0_mx_floor time_us 184.38400328159332 mem_bw_gbps 4413.045391781173 (pytorch_nightly) [[email protected] ~/local/ao (20250728_mx_expose_scale)]$ python benchmarks/mx_formats/cast_bench.py --mode dim0_mx_rceil M 16384 K 16384 BLOCK_SIZE 32 GPU: NVIDIA B200 torch version: 2.9.0.dev20250724+cu128 triton version: 3.4.0 mode: dim0_mx_rceil time_us 143.39199662208557 mem_bw_gbps 5674.619191924083 ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: aec9d07 ghstack-comment-id: 3129597761 Pull-Request: #2620
vkuzo
added a commit
that referenced
this pull request
Aug 1, 2025
Summary: Test Plan: performance on individual cast ```bash (pytorch_nightly) [[email protected] ~/local/ao (20250728_mx_expose_scale)]$ python benchmarks/mx_formats/cast_bench.py --mode dim0_mx_floor M 16384 K 16384 BLOCK_SIZE 32 GPU: NVIDIA B200 torch version: 2.9.0.dev20250724+cu128 triton version: 3.4.0 mode: dim0_mx_floor time_us 184.38400328159332 mem_bw_gbps 4413.045391781173 (pytorch_nightly) [[email protected] ~/local/ao (20250728_mx_expose_scale)]$ python benchmarks/mx_formats/cast_bench.py --mode dim0_mx_rceil M 16384 K 16384 BLOCK_SIZE 32 GPU: NVIDIA B200 torch version: 2.9.0.dev20250724+cu128 triton version: 3.4.0 mode: dim0_mx_rceil time_us 143.39199662208557 mem_bw_gbps 5674.619191924083 ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 0531997 ghstack-comment-id: 3129597761 Pull-Request: #2620
vkuzo
added a commit
that referenced
this pull request
Aug 1, 2025
Summary: Test Plan: performance on individual cast ```bash (pytorch_nightly) [[email protected] ~/local/ao (20250728_mx_expose_scale)]$ python benchmarks/mx_formats/cast_bench.py --mode dim0_mx_floor M 16384 K 16384 BLOCK_SIZE 32 GPU: NVIDIA B200 torch version: 2.9.0.dev20250724+cu128 triton version: 3.4.0 mode: dim0_mx_floor time_us 184.38400328159332 mem_bw_gbps 4413.045391781173 (pytorch_nightly) [[email protected] ~/local/ao (20250728_mx_expose_scale)]$ python benchmarks/mx_formats/cast_bench.py --mode dim0_mx_rceil M 16384 K 16384 BLOCK_SIZE 32 GPU: NVIDIA B200 torch version: 2.9.0.dev20250724+cu128 triton version: 3.4.0 mode: dim0_mx_rceil time_us 143.39199662208557 mem_bw_gbps 5674.619191924083 ``` Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 2b36350 ghstack-comment-id: 3129597761 Pull-Request: #2620
danielvegamyhre
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
topic: improvement
Use this tag if this PR is an improvement (doesn't fit into any of the other categories)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
To prepare MX for graduating out of prototype, exposes the scaling mode at the top level training config and recipe. The two well supported scaling modes are FLOOR and RCEIL. CEIL has not been well tested, and EVEN does not work with torch.compile yet. We may further adjust these options in future PRs.
Note that for
RCEIL
, the dim0 casts are not yet using hardware accelerated instructions, so overall performance is currently slightly belowFLOOR
. We can improve this in a future PR.Test Plan:
unit tests:
performance on llama 3 8b training:
performance on individual cast
Reviewers:
Subscribers:
Tasks:
Tags: