Skip to content

mx: make CUDA kernel for dim1 cast in mxfp8_cublas recipe #2661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 4, 2025

Conversation

vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Aug 1, 2025

Summary:

As titled, this is the fastest option right now so should be default.

Test Plan:

pytest test/prototype/mx_formats/ -s -x

Reviewers:

Subscribers:

Tasks:

Tags:

vkuzo added 4 commits July 28, 2025 13:30
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@vkuzo
Copy link
Contributor Author

vkuzo commented Aug 1, 2025

Stack from ghstack (oldest at bottom):

Copy link

pytorch-bot bot commented Aug 1, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2661

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 13 Pending, 1 Unrelated Failure

As of commit aa7c790 with merge base c993d64 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

vkuzo added a commit that referenced this pull request Aug 1, 2025
Summary:

As titled, this is the fastest option right now so should be default.

Test Plan:

```bash
pytest test/prototype/mx_formats/ -s -x
```

Reviewers:

Subscribers:

Tasks:

Tags:
ghstack-source-id: d7b6c3e
ghstack-comment-id: 3144899603
Pull-Request: #2661
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 1, 2025
@vkuzo vkuzo added the topic: improvement Use this tag if this PR is an improvement (doesn't fit into any of the other categories) label Aug 1, 2025
[ghstack-poisoned]
@vkuzo vkuzo changed the base branch from gh/vkuzo/99/head to main August 4, 2025 17:01
vkuzo added a commit that referenced this pull request Aug 4, 2025
Summary:

As titled, this is the fastest option right now so should be default.

Test Plan:

```bash
pytest test/prototype/mx_formats/ -s -x
```

Reviewers:

Subscribers:

Tasks:

Tags:
ghstack-source-id: 52eb5cd
ghstack-comment-id: 3144899603
Pull-Request: #2661
@vkuzo vkuzo merged commit 5f3ab63 into main Aug 4, 2025
35 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: improvement Use this tag if this PR is an improvement (doesn't fit into any of the other categories)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants