Skip to content

support for 2d-2d emulated mxfp8 grouped gemm #2632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2025

Conversation

danielvegamyhre
Copy link
Contributor

@danielvegamyhre danielvegamyhre commented Jul 30, 2025

Stacked PRs:


Summary

  • Add torch implementations of per-token-group scaling for mxfp8 (needed for 2d-2d grouped gemm calculation of dW in backward)
  • Add support for 2d-2d emulated mxfp8 grouped gemm
  • Add unit tests verifying numerical accuracy

Test plan

  • pytest test/prototype/moe_training/test_scaled_grouped_mm.py

Copy link

pytorch-bot bot commented Jul 30, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2632

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 1 Cancelled Job, 1 Pending

As of commit f6c2c3a with merge base 3c466f8 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

danielvegamyhre added a commit that referenced this pull request Jul 30, 2025
stack-info: PR: #2632, branch: danielvegamyhre/stack/24
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 30, 2025
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/24 branch from 7837095 to fb9d67c Compare July 30, 2025 15:31
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/23 branch from fd92301 to 18991a4 Compare July 30, 2025 15:31
danielvegamyhre added a commit that referenced this pull request Jul 30, 2025
stack-info: PR: #2632, branch: danielvegamyhre/stack/24
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/24 branch from fb9d67c to 254b1a1 Compare July 30, 2025 15:31
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/23 to main July 30, 2025 15:38
danielvegamyhre added a commit that referenced this pull request Jul 30, 2025
stack-info: PR: #2632, branch: danielvegamyhre/stack/24
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/24 branch from 254b1a1 to 50b5e70 Compare July 30, 2025 15:38
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/23 July 30, 2025 15:38
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/23 to main July 30, 2025 18:00
danielvegamyhre added a commit that referenced this pull request Jul 30, 2025
stack-info: PR: #2632, branch: danielvegamyhre/stack/24
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/24 branch from 50b5e70 to c8e0897 Compare July 30, 2025 18:00
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/23 July 30, 2025 18:00
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/23 to main July 30, 2025 19:50
danielvegamyhre added a commit that referenced this pull request Jul 30, 2025
stack-info: PR: #2632, branch: danielvegamyhre/stack/24
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/24 branch from c8e0897 to 3d66ed3 Compare July 30, 2025 19:50
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/23 July 30, 2025 19:50
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/23 to main July 30, 2025 20:05
danielvegamyhre added a commit that referenced this pull request Jul 30, 2025
stack-info: PR: #2632, branch: danielvegamyhre/stack/24
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/24 branch from 3d66ed3 to 39b5fbf Compare July 30, 2025 20:05
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/23 July 30, 2025 20:05
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/23 to main July 30, 2025 21:48
danielvegamyhre added a commit that referenced this pull request Jul 30, 2025
stack-info: PR: #2632, branch: danielvegamyhre/stack/24
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/24 branch from 39b5fbf to 6400cde Compare July 30, 2025 21:48
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/23 July 30, 2025 21:48
danielvegamyhre added a commit that referenced this pull request Jul 30, 2025
stack-info: PR: #2632, branch: danielvegamyhre/stack/24
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/23 to main July 30, 2025 21:49
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/24 branch from 6400cde to 9eab410 Compare July 30, 2025 21:49
danielvegamyhre added a commit that referenced this pull request Jul 30, 2025
stack-info: PR: #2632, branch: danielvegamyhre/stack/24
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/24 branch from 9eab410 to 64ebbc2 Compare July 30, 2025 21:52
danielvegamyhre added a commit that referenced this pull request Jul 30, 2025
stack-info: PR: #2632, branch: danielvegamyhre/stack/24
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/24 branch from 64ebbc2 to 013a3d2 Compare July 30, 2025 21:53
@danielvegamyhre danielvegamyhre changed the title mxfp8 grouped mm backward pass support for 2d-2d emulated mxfp8 grouped gemm Jul 30, 2025
@danielvegamyhre danielvegamyhre added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Jul 30, 2025
stack-info: PR: #2632, branch: danielvegamyhre/stack/24
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/24 branch from 013a3d2 to f6c2c3a Compare August 1, 2025 18:37
@danielvegamyhre danielvegamyhre merged commit 5ef75e2 into main Aug 1, 2025
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants