backward pass for differentiable mxfp8 grouped gemm with dynamic quant #2639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stack-info: PR: #2639, branch: danielvegamyhre/stack/25
danielvegamyhre
added a commit
that referenced
this pull request
Jul 30, 2025
stack-info: PR: #2639, branch: danielvegamyhre/stack/25
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2639
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
danielvegamyhre
force-pushed
the
danielvegamyhre/stack/25
branch
from
f866e23 to
7a8b843
Compare
meta-cla
bot
added
the
CLA Signed
danielvegamyhre
added
the
topic: not user facing
vkuzo
reviewed
Aug 1, 2025
| ) | ||
|
|
||
| # Check weight grads | ||
| min_weight_grad_sqnr = 24.0 |
vkuzo
approved these changes
Aug 1, 2025
danielvegamyhre
force-pushed
the
danielvegamyhre/stack/25
branch
from
7a8b843 to
e9ba18b
Compare
danielvegamyhre
force-pushed
the
danielvegamyhre/stack/25
branch
from
e9ba18b to
2aabb15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
backward pass for differentiable mxfp8 grouped gemm with dynamic quant
Summary
Test plan
pytest test/prototype/moe_training/test_scaled_grouped_mm.py