Prefix target_link_options_shared_lib with executorch_
#12667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced Jul 21, 2025
This was referenced Jul 21, 2025
This was referenced Jul 23, 2025
|
build-demo-ios is an infra failure and test-llava-runner-linux is known to flake, merging shortly |
had to rebase. also, didn't realize the PR isn't reviewed |
swolchok
changed the title
executorch_
jathu
approved these changes
Jul 23, 2025
|
merging based on previous green CI; red jobs appears to be due to upstream respository issues and most are green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we are getting build failures in the following PR (e.g., in QNN) because tokenizers has a copy/paste of this function that I changed to work differently. If this works out, we should namespace all our functions.