Skip to content

Prefix target_link_options_shared_lib with executorch_ #12667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 56 commits into from
Jul 23, 2025

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Jul 21, 2025

I think we are getting build failures in the following PR (e.g., in QNN) because tokenizers has a copy/paste of this function that I changed to work differently. If this works out, we should namespace all our functions.

swolchok added 30 commits July 13, 2025 09:47
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
swolchok added 4 commits July 21, 2025 10:41
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@swolchok swolchok requested a review from SS-JIA as a code owner July 21, 2025 23:05
swolchok added 5 commits July 22, 2025 10:13
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@swolchok swolchok added the release notes: none Do not include this in the release notes label Jul 22, 2025
Base automatically changed from gh/swolchok/517/head to main July 22, 2025 22:33
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

build-demo-ios is an infra failure and test-llava-runner-linux is known to flake, merging shortly

swolchok added 2 commits July 23, 2025 11:07
[ghstack-poisoned]
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

merging shortly

had to rebase. also, didn't realize the PR isn't reviewed

@swolchok swolchok changed the title Prefix target_link_options_shared_lib with ExecuTorch Prefix target_link_options_shared_lib with executorch_ Jul 23, 2025
@swolchok
Copy link
Contributor Author

merging based on previous green CI; red jobs appears to be due to upstream respository issues and most are green

@swolchok swolchok merged commit f6f5796 into main Jul 23, 2025
267 of 300 checks passed
@swolchok swolchok deleted the gh/swolchok/522/head branch July 23, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants