refactor FTManager #1397
Merged
refactor FTManager #1397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Merged
H-Huang
approved these changes
Jul 15, 2025
| if self.ft_manager.enabled: | ||
| dp_degree, dp_rank = self.ft_manager.get_dp_info(dp_degree, dp_rank) | ||
| self.ft_manager = FTManager(job_config.fault_tolerance) | ||
| dp_degree, dp_rank = self.ft_manager.get_dp_info(dp_degree, dp_rank) |
There was a problem hiding this comment.
i looks like dp_degree and dp_rank are needed for the dataloader. If we move the dataloader initialization after the model initialization, then I think we can also move maybe_set_all_reduce_hook here to consolidate all the torchft code together.
Can look into it in a follow up PR
wwwjn
approved these changes
Jul 15, 2025
tianyu-l
added a commit
that referenced
this pull request
Jul 23, 2025
idoh
pushed a commit
to idoh/torchtitan
that referenced
this pull request
Jul 28, 2025
This PR refactors `FTManager` to: 1. simplify construction logic 2. expose simpler interfact to `train.py` 3. make it optional when building optimizer and some other minor improvements.
idoh
pushed a commit
to idoh/torchtitan
that referenced
this pull request
Jul 28, 2025
depending on pytorch#1384 and pytorch#1397
bentherien
pushed a commit
to bentherien/torchtitan_
that referenced
this pull request
Aug 5, 2025
depending on pytorch#1384 and pytorch#1397
joellidin
pushed a commit
to tplr-ai/torchtitan
that referenced
this pull request
Aug 8, 2025
depending on pytorch#1384 and pytorch#1397
joellidin
pushed a commit
to tplr-ai/torchtitan
that referenced
this pull request
Aug 8, 2025
depending on pytorch#1384 and pytorch#1397
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
FTManagerto:train.pyand some other minor improvements.