Added route and serializer for fetching output curves in bulk #1613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noracato
reviewed
Aug 21, 2025
| # Returns a single CSV file with specified output curves as columns. | ||
| # Query parameter 'curve_types' specifies which curves to include (comma-separated). | ||
| def bulk_output_curves | ||
| curve_types = params[:curve_types]&.split(',')&.map(&:strip) |
There was a problem hiding this comment.
Let's do this with permit as []
There was a problem hiding this comment.
Or even with a require? That way we can tackle an empty csv automagically before we move into the serializer
Comment on lines
+6
to
+9
| def initialize(scenario, curve_types) | ||
| @scenario = scenario | ||
| @curve_types = curve_types || [] | ||
| end |
There was a problem hiding this comment.
Suggested change
| def initialize(scenario, curve_types) | |
| @scenario = scenario | |
| @curve_types = curve_types || [] | |
| end | |
| def initialize(scenario, curve_types = []) | |
| @scenario = scenario | |
| @curve_types = curve_types | |
| end |
| end | ||
|
|
||
| max_len = curves.values.map(&:length).max || 0 | ||
| require 'csv' |
There was a problem hiding this comment.
We can move this one to the top!
| @@ -26,6 +26,7 @@ | |||
| get :costs_parameters, to: 'export#costs_parameters' | |||
| get :sankey, to: 'export#sankey' | |||
| get :storage_parameters, to: 'export#storage_parameters' | |||
| get :bulk_output_curves, to: 'export#bulk_output_curves' | |||
There was a problem hiding this comment.
I'm thinking the endpoint is already called (output)curves. Maybe we can rename this to just bulk or combined for clarity? What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetching the curves this way speeds up the exports for pyetm by about a minute.
Goes with this pyetm PR