Update the exports to rely on the bulk endpoint for speed #74
+61
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louispt1
force-pushed
the
concurrency
branch
2 times, most recently
from
5d9c1a2 to
d7b3401
Compare
noracato
approved these changes
Aug 22, 2025
Comment on lines
+71
to
+96
| df = pd.read_csv(io.StringIO(csv_text), index_col=0) | ||
| except Exception as e: | ||
| return ServiceResult.fail([f"Failed to parse bulk CSV: {e}"]) | ||
|
|
||
| results: Dict[str, io.StringIO] = {} | ||
| warnings: list[str] = [] | ||
|
|
||
| groups: Dict[str, list[str]] = {} | ||
| for col in df.columns: | ||
| base = str(col) | ||
| for sep in (":", "/"): | ||
| if sep in base: | ||
| base = base.split(sep, 1)[0] | ||
| break | ||
| groups.setdefault(base, []).append(col) | ||
|
|
||
| for base, cols in groups.items(): | ||
| try: | ||
| sub = df[cols].dropna(how="all") | ||
| buf = io.StringIO() | ||
| sub.to_csv(buf, index=True) | ||
| buf.seek(0) | ||
| results[base] = buf | ||
| except Exception as e: | ||
| warnings.append(f"{base}: Failed to prepare CSV: {e}") | ||
|
|
There was a problem hiding this comment.
This logic does not belong here unfortunately. But we can fix it later.
|
@noracato I think with the new async approach this is an unnecessary change - it is 5 seconds slower than the async approach. If you agree I would close this PR and the Engine one as they are unnecessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes with this PR for ETEngine