-
Notifications
You must be signed in to change notification settings - Fork 19
update runtime-minimal image for ppc64le #1330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: AaruniAggarwal <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
python3.12::
Python3.11::
images::
|
Hi @AaruniAggarwal, just out of curiosity—was there a specific reason for creating the feature branch on the downstream repo instead of under opendatahub-io/notebooks? |
Hi aTheo, |
Thanks for the response. We recently added the |
I just remembered your upstream PR: https://github.com/opendatahub-io/notebooks/pull/1175/files. Since it's now merged upstream, you might want to apply the same upgrade to the py312 image, as that change hasn’t been included there yet. |
Thanks aTheo, I have created a similar PR for python3.12 in opendatahub-io/notebooks : |
Thanks, @AaruniAggarwal. Can I go ahead and close this one? Have you completed the Konflux test? |
Hi @atheo89 , I can see here konflux related checks for ppc64le image are passing for both python3.11 and 3.12 . took some snapshots from konflux. Is anything else also needs to be done? |
Great, thank you, I thing is fine. |
This PR adds additional packages in minimal runtime Dockerfile.cpu for ppc64le as pyzmq require them. Without these changes, image is failing to build on ppc64le with following error:
This change ensures notebook runtime minimal builds are successfull on IBM Power (ppc64le) and it will not impact to x86_64 builds.
Tested on: ppc64le
Able to build runtime-minimal image for both python3.11 and python3.12 with these changes.