fix(container-runner): fix leaked pipes #2473
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying rivet with
|
| Latest commit: |
e24b05c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://111e0c16.rivet.pages.dev |
| Branch Preview URL: | https://05-25-fix-container-runner-f.rivet.pages.dev |
NathanFlurry
force-pushed
the
05-25-fix_container-runner_fix_leaked_pipes
branch
2 times, most recently
from
089a707 to
057e946
Compare
MasterPtato
force-pushed
the
05-25-fix_container-runner_fix_leaked_pipes
branch
from
057e946 to
e24b05c
Compare
Deploying rivet-studio with
|
| Latest commit: |
e24b05c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f7738b0f.rivet-studio.pages.dev |
| Branch Preview URL: | https://05-25-fix-container-runner-f.rivet-studio.pages.dev |
MasterPtato
changed the base branch from
graphite-base/2473
to
05-23-disambiguate_cluster_id_-_instance_id
This was referenced May 26, 2025
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR addresses pipe leaks in the container-runner by redirecting stdout and stderr to null during command execution, particularly for container management operations.
- Added
stdout(Stdio::null())andstderr(Stdio::null())torunc killcommand inpackages/edge/infra/client/container-runner/src/container.rsto prevent pipe leaks during SIGTERM handling - Modified
packages/edge/infra/client/container-runner/tests/common/setup.rsto redirect output to null forskopeo,umoci, and container deletion commands - Added output redirection in
signal_childmethod to prevent leaks during test signal handling
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Deploying rivet-hub with
|
| Latest commit: |
e24b05c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6186c002.rivet-hub-7jb.pages.dev |
| Branch Preview URL: | https://05-25-fix-container-runner-f.rivet-hub-7jb.pages.dev |
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
May 26, 2025
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
This was referenced May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes