Skip to content

Conversation

@pcf0
Copy link

@pcf0 pcf0 commented Nov 2, 2025

FFMpegArgumentOptions.WithArgument is already public, which allows extensions.
However, this is not nice semantically, as the global arguments (e.g. -hide_banner, -nostats) have to be given as input arguments.

So I changed the other two methods of the classes FFMpegGlobalArguments and VideoFilterOptions from private to public to allow an extension here as well.
I have changed the name of the method FFMpegGlobalArguments.WithOption() to FFMpegGlobalArguments.WithArgument() so that it is consistent.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.72%. Comparing base (1c4333e) to head (9f779a5).
⚠️ Report is 195 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #603      +/-   ##
==========================================
+ Coverage   71.20%   71.72%   +0.51%     
==========================================
  Files         117      123       +6     
  Lines        2973     3544     +571     
  Branches      284      311      +27     
==========================================
+ Hits         2117     2542     +425     
- Misses        751      888     +137     
- Partials      105      114       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pcf0 pcf0 mentioned this pull request Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants