Skip to content

Change private WithArgument methods to public #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change private WithArgument methods to public #603

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion FFMpegCore/FFMpeg/Arguments/VideoFiltersArgument.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ public VideoFilterOptions Pad(PadOptions padOptions)
return WithArgument(new PadArgument(padOptions));
}

private VideoFilterOptions WithArgument(IVideoFilterArgument argument)
public VideoFilterOptions WithArgument(IVideoFilterArgument argument)
{
Arguments.Add(argument);
return this;
Expand Down
4 changes: 2 additions & 2 deletions FFMpegCore/FFMpeg/FFMpegGlobalArguments.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ internal FFMpegGlobalArguments() { }

public FFMpegGlobalArguments WithVerbosityLevel(VerbosityLevel verbosityLevel = VerbosityLevel.Error)
{
return WithOption(new VerbosityLevelArgument(verbosityLevel));
return WithArgument(new VerbosityLevelArgument(verbosityLevel));
}

private FFMpegGlobalArguments WithOption(IArgument argument)
public FFMpegGlobalArguments WithArgument(IArgument argument)
{
Arguments.Add(argument);
return this;
Expand Down