Skip to content

exporter: Format frame filenames with leading zeros in screenshot captures #20928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2025
Merged

exporter: Format frame filenames with leading zeros in screenshot captures #20928

merged 1 commit into from
Jul 15, 2025

Conversation

@AeroXuk
Copy link
Contributor

@AeroXuk AeroXuk commented Jul 5, 2025 •
edited
Loading

Split from #20896

  • Zero-pad filenames when exporting multiple frames to a directory, ensuring proper sort order and compatibility with external tools (such as ffmpeg).

@AeroXuk AeroXuk changed the title Format frame filenames with leading zeros in screenshot captures exporter: Format frame filenames with leading zeros in screenshot captures Jul 5, 2025
@AeroXuk AeroXuk mentioned this pull request Jul 5, 2025
Closed
@kjarosh kjarosh added exporter Issues related to the exporter tool A-other Area: Not covered by other area labels T-fix Type: Bug fix (in something that's supposed to work already) labels Jul 7, 2025
Dinnerbone
Dinnerbone approved these changes Jul 15, 2025
View reviewed changes
Copy link
Contributor

@Dinnerbone Dinnerbone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Dinnerbone Dinnerbone enabled auto-merge (rebase) July 15, 2025 16:55
@Dinnerbone Dinnerbone force-pushed the feature/exporter_padded_frame_numbers branch from 7070c50 to 09c0965 Compare July 15, 2025 16:55
@Dinnerbone Dinnerbone merged commit ba02cfd into ruffle-rs:master Jul 15, 2025
24 checks passed
Hancock33 added a commit to Hancock33/batocera.piboy that referenced this pull request Jul 16, 2025
@Hancock33
Updates on Jul 16, 2025 19:46
c21247e 
-------------------------------------------------------------------------------------
zmusic.mk ceb92b5fcea76b62f4f04c17f687d882c95b61b3 # Version: Commits on Jul 05, 2025
-------------------------------------------------------------------------------------
configuration.cpp: Don't confuse playback

Don't try to change settings if not the same synth is running. Otherwise, this might cause various odd behaviour cases like taking of changes at wrong synth.

(Even conditions are fine),

-----------------------------------------------------------------------------------
cemu.mk 42ff3ad4683647cf82b616e1990a0df855282c59 # Version: Commits on Jul 16, 2025
-----------------------------------------------------------------------------------
Fix debug assert that'd occur when closing the debug menu

Closing the settings window will immediately flush a temporary 0, 0 value it writes for the size which gets overwritten by the MainWindow a few seconds later.

In the code, -1 is considered the \off\ state, and 0 is considered a \it should be saved, but only whenever the value is available\. The save gamepad size/pos option already worked like this new behavior, since you might enable the option but not (previously) have it open yet. When encountering a 0 as the size, it'll just use the default window size of Cemu.,

------------------------------------------------------------------------------------------
dolphin-emu.mk c2bace5967384140a67c1b1529f9b3fb3dddf83f # Version: Commits on Jul 16, 2025
------------------------------------------------------------------------------------------
Merge pull request #13798 from TryTwo/PR_CodeWidget_NoUpdate

CodeWidget: Add button that locks the view's address,

------------------------------------------------------------------------------------------
duckstation.mk da6ba416c98cbe34b5510c6f187da8e955ce05b6 # Version: Commits on Jul 16, 2025
------------------------------------------------------------------------------------------
Updated Swedish translation (#3481),

---------------------------------------------------
pcsx2.mk v2.5.66 # Version: Commits on Jul 16, 2025
---------------------------------------------------
- [GS/HW: Add CRC for Sand Grain Games palette shuffle effect.](PCSX2/pcsx2#13005)

-----------------------------------------------------------------------------------
play.mk 45ef864b381ac3c33c671363cd63c4afa53bd97e # Version: Commits on Jul 16, 2025
-----------------------------------------------------------------------------------
Merge pull request #1475 from Zer0xFF/shortcuts

Add Few Qt Shortcuts,

-------------------------------------------------------------------------------------
ppsspp.mk a859fb95c38da106c54932903ace68aae875c167 # Version: Commits on Jul 16, 2025
-------------------------------------------------------------------------------------
Merge pull request #20636 from lrzlin/loong-commit

loongarch: Initial VertexJIT support and bug fix,

------------------------------------------------------------------------------------
rpcs3.mk 06f480cb83888741cfad8d9796de1160e46baf5a # Version: Commits on Jul 15, 2025
------------------------------------------------------------------------------------
VS: add quotes around paths

Fixes use with paths that contain spaces.,

---------------------------------------------------------------
ruffle.mk nightly-2025-07-16 # Version: Commits on Jul 16, 2025
---------------------------------------------------------------
## What's Changed

* build(deps-dev): bump the npm-minor group in /web with 10 updates by @dependabot[bot] in ruffle-rs/ruffle#21005

* build(deps): bump the cargo-minor group across 1 directory with 6 updates by @dependabot[bot] in ruffle-rs/ruffle#21010

* exporter: Format frame filenames with leading zeros in screenshot captures by @AeroXuk in ruffle-rs/ruffle#20928

**Full Changelog**: ruffle-rs/ruffle@nightly-2025-07-15...nightly-2025-07-16,

--------------------------------------------------------------------------------------
shadps4.mk fddded8d204374febcba210b8e2e325973f973b2 # Version: Commits on Jul 16, 2025
--------------------------------------------------------------------------------------
Add an unreachable on hitting ud2 instead of getting stuck in an infinite loop (#3257)

* Add an unreachable on hitting ud2 instead of getting stuck in an infinite loop

* Add [[unlikely]] to get ahead of the inevitable PR review comment,

---------------------------------------------------------------------------------------
thextech.mk db6a4d049566223f40f6ec6cc95a0ff69cea9852 # Version: Commits on Jul 16, 2025
---------------------------------------------------------------------------------------
Translated using Weblate (Chinese (Simplified Han script))

Currently translated at 100.0% (677 of 677 strings)

Co-authored-by: 迎春心情 <[email protected]>

Translate-URL: https://hosted.weblate.org/projects/thextech/engine-general/zh_Hans/

Translation: TheXTech Engine/Engine General,

-----------------------------------------------------------------------------------
ymir.mk 6ba98e1f7015e66dff8c843a4ad6bb794afae125 # Version: Commits on Jul 16, 2025
-----------------------------------------------------------------------------------
chore(settings): Clarify settings related to the frame rate OSD,

------------------------------------------------------------------------------------
box64.mk ef2f960d4ba7557b2baa26cd65b012b9a3363cbd # Version: Commits on Jul 16, 2025
------------------------------------------------------------------------------------
[ARM64_DYNAREC] Added 64/65 F3 0F 7F opcode,

------------------------------------------------------------------------------------
cdogs.mk b741745b5c44ec677264175aa3cc9b5d33191a11 # Version: Commits on Jul 16, 2025
------------------------------------------------------------------------------------
Monkey weapon #712,

---------------------------------------------------------------------------------------
corsixth.mk 0a5214a01b7644a497bd9ff25f872ef66c619df4 # Version: Commits on Jul 15, 2025
---------------------------------------------------------------------------------------
Merge pull request #2937 from tobylane/revertinstallerfont

Revert \Download Noto font and include in Windows installer\,

----------------------------------------------------------------------------------------
openjkdf2.mk fbe9d821fa096a81615ea8d681ec551049ff8fd9 # Version: Commits on Jul 16, 2025
----------------------------------------------------------------------------------------
Purge devkitpro [sic] and replace with BlocksDS,

----------------------------------------------------------------------------------------
openmohaa.mk 3e842ffe405e574003cb69aafbff14d2ac8d4743 # Version: Commits on Jul 15, 2025
----------------------------------------------------------------------------------------
Redefine aliases for WSA errors instead on win32,

----------------------------------------------------------------------------------------
supertux2.mk 25753a1420e1dad8fa244f01e517c41339786855 # Version: Commits on Jul 16, 2025
----------------------------------------------------------------------------------------
Less code duplication, pass Vector value by reference,

----------------------------------------------------------------------------------------
doomretro.mk 804902c4602b65e5c04ab3eb02994b2df5ed1374 # Version: Commits on Jul 16, 2025
----------------------------------------------------------------------------------------
Try to always use correct colors for MBF helper dogs,

-------------------------------------------------------------------------------------
gzdoom.mk c4b4705acf4ecf94054e7fc91c9ddb95af2f6f5a # Version: Commits on Jul 15, 2025
-------------------------------------------------------------------------------------
- update CI deps to temporary archives until next release,

------------------------------------------------------------------------------------------
xash3d-fwgs.mk 4c9b69af5f0ac30866a7cff91e815b80a4fe3ad7 # Version: Commits on Jul 16, 2025
------------------------------------------------------------------------------------------
engine: mod_bmodel: allow firstclipnode index to be negative, as maps compiled with it rely on this trick by encoding whole hull as empty contents,

---------------------------------------------------------------------------------------------
libretro-fbneo.mk 4f8f941827bc34c9a7a86ab896e766966f21d3f3 # Version: Commits on Jul 16, 2025
---------------------------------------------------------------------------------------------
(libretro) update files,

--------------------------------------------------------------------------------------------------------------
libretro-genesisplusgx-expanded.mk 258749423d02e9cba34ef4221c91ea3e01cef126 # Version: Commits on Jul 16, 2025
--------------------------------------------------------------------------------------------------------------
Update lr-genesis-plus-gx-EX.sh,

--------------------------------------------------------------------------------------------
libretro-play.mk 45ef864b381ac3c33c671363cd63c4afa53bd97e # Version: Commits on Jul 16, 2025
--------------------------------------------------------------------------------------------
Merge pull request #1475 from Zer0xFF/shortcuts

Add Few Qt Shortcuts,

----------------------------------------------------------------------------------------------
libretro-ppsspp.mk a859fb95c38da106c54932903ace68aae875c167 # Version: Commits on Jul 16, 2025
----------------------------------------------------------------------------------------------
Merge pull request #20636 from lrzlin/loong-commit

loongarch: Initial VertexJIT support and bug fix,

---------------------------------------------------------------------------------------------
libretro-vba-m.mk 53f5ec7b7d2d73f19ddfbd942a52cc3add389228 # Version: Commits on Jul 16, 2025
---------------------------------------------------------------------------------------------
build: fix building with OpenAL enabled

Signed-off-by: Rafael Kitover <[email protected]>,
@AeroXuk AeroXuk deleted the feature/exporter_padded_frame_numbers branch August 10, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dinnerbone Dinnerbone Dinnerbone approved these changes

Assignees

No one assigned

Labels

A-other Area: Not covered by other area labels exporter Issues related to the exporter tool T-fix Type: Bug fix (in something that's supposed to work already)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AeroXuk @Dinnerbone @kjarosh