exporter: Add Support for Full Auto-Export, End-on-Last-Frame Logic, and Prevent --force-play Looping #20896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjarosh
reviewed
Jul 2, 2025
Comment on lines
+55
to
+56
| /// Number of frames to capture per file. | ||
| /// If set to 0, all frames in the SWF's main timeline will be captured |
There was a problem hiding this comment.
It makes more sense for me to pass --frames all instead of --frames 0 to capture all frames. It looks non-intuitive
There was a problem hiding this comment.
I'll look into this but I'm still quite new to rust, so not 100% sure what the best way to implement a cli command that takes a string or number would be
There was a problem hiding this comment.
I've done some research and hope I've found the right way to implement this.
I need to run a few more tests, but I've raised this as #20930.
Comment on lines
+182
to
+184
| if is_root_movie_clip_at_end(&player) { | ||
| break; | ||
| } |
There was a problem hiding this comment.
That will break some animations, it has to be another CLI option
There was a problem hiding this comment.
Made a new cli command and raised under #20929
kjarosh
added
exporter
This was referenced Jul 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know if you'd like any of these features to be placed behind new CLI arguments. I'm happy to update the PR accordingly.
Changes for the Exporter Tool:
--frames 0to export all frames. exporter: Update --frames to accept "all" to export all frames #20930--force-playfeature to avoid restarting the timeline if it's already on the last frame. exporter: Refactor force_root_clip_play to prevent force play from looping. #20927