Skip to content

exporter: Update --frames to accept "all" to export all frames #20930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 23, 2025
Merged

exporter: Update --frames to accept "all" to export all frames #20930

merged 1 commit into from
Aug 23, 2025
+62 −17

Conversation

@AeroXuk
Copy link
Contributor

@AeroXuk AeroXuk commented Jul 5, 2025

Split from #20896

  • Support --frames all to export all frames.

@AeroXuk AeroXuk changed the title Update frames cli command to accept "all" to export all frames. exporter: Update frames cli command to accept "all" to export all frames. Jul 5, 2025
@AeroXuk AeroXuk changed the title exporter: Update frames cli command to accept "all" to export all frames. exporter: Update --frames to accept "all" to export all frames Jul 5, 2025
@AeroXuk AeroXuk mentioned this pull request Jul 5, 2025
Closed
kjarosh
kjarosh reviewed Jul 5, 2025
View reviewed changes
@kjarosh
Copy link
Member

kjarosh commented Jul 5, 2025

Your approach of parsing FrameSelection is the right way to do it!

@kjarosh kjarosh added exporter Issues related to the exporter tool A-other Area: Not covered by other area labels T-feature Type: New Feature (that Flash doesn't have) labels Jul 7, 2025
@kjarosh
Copy link
Member

kjarosh commented Jul 20, 2025

I'm sorry for stalling your exporter PRs, I've been adding some tests for exporter so that we don't break existing use cases and we can cover future ones (#21029, #21042).

I think the PRs can be rebased now (the main.rs diff should apply to lib.rs now).

@AeroXuk
Copy link
Contributor Author

AeroXuk commented Jul 25, 2025

I'm sorry for stalling your exporter PRs, I've been adding some tests for exporter so that we don't break existing use cases and we can cover future ones (#21029, #21042).

I think the PRs can be rebased now (the main.rs diff should apply to lib.rs now).

Thanks for the update, that's a great idea adding the test cases. I'll see if I can get some time this weekend to go through and update my still open PRs.

@Lord-McSweeney Lord-McSweeney added the waiting-on-author Waiting on the PR author to make the requested changes label Aug 3, 2025
@AeroXuk AeroXuk force-pushed the feature/exporter_all_frames2 branch from 6430d38 to f1d4a1c Compare August 10, 2025 11:56
@AeroXuk
Copy link
Contributor Author

AeroXuk commented Aug 10, 2025

@kjarosh Sorry for the delay in getting back to this. I have rebased all the PRs against master now that the logic is moved into lib.rs

kjarosh
kjarosh approved these changes Aug 23, 2025
View reviewed changes
Copy link
Member

@kjarosh kjarosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@kjarosh kjarosh force-pushed the feature/exporter_all_frames2 branch from f1d4a1c to bf65609 Compare August 23, 2025 12:13
@kjarosh kjarosh enabled auto-merge (squash) August 23, 2025 12:14
@kjarosh kjarosh merged commit 4e6b841 into ruffle-rs:master Aug 23, 2025
25 checks passed
Hancock33 added a commit to Hancock33/batocera.piboy that referenced this pull request Aug 24, 2025
@Hancock33
Updates on Aug 24, 2025 06:37
8e738c3 
---------------------------------------------------------------------------------------
amiberry.mk aa67458e8012fa49ec4502da360dfac3e4fc0d46 # Version: Commits on Aug 23, 2025
---------------------------------------------------------------------------------------
enhancement: Support broken cue files with \TRACK 0\ instead of \TRACK 01\. (fixes #1691),

----------------------------------------------------------------------------------
clk.mk 57df6d9bf72e85c56042fd1bd1cd395a4f99708c # Version: Commits on Aug 24, 2025
----------------------------------------------------------------------------------
Merge pull request #1538 from TomHarte/LessMemory

Reduce AT to 640kb RAM.,

------------------------------------------------------------------------------------------
dolphin-emu.mk 2b7faeb920da31edb11f01c9a0473f86e4023100 # Version: Commits on Aug 24, 2025
------------------------------------------------------------------------------------------
Merge pull request #13894 from iwubcode/material_asset_update

VideoCommon: update material asset to support additional features in custom pipelines,

------------------------------------------------------------------------------------------
duckstation.mk 1ef1a2d3f4e473df3ddf461e9334bf654d374454 # Version: Commits on Aug 24, 2025
------------------------------------------------------------------------------------------
System: Add XZ save state compression

For when space is really at a premium.

Also use CompressHelpers to reduce duplication.,

----------------------------------------------------
pcsx2.mk v2.5.122 # Version: Commits on Aug 24, 2025
----------------------------------------------------
- [GameDB: Add memcard filters for Gundam series (Limited Edition)](PCSX2/pcsx2#13167)

-------------------------------------------------------------------------------------
ppsspp.mk 79f222692428cc2fe775a2de2e18c416d2b9fb1b # Version: Commits on Aug 23, 2025
-------------------------------------------------------------------------------------
Merge pull request #20737 from Samueru-sama/master

simplify deps install, use mesa that does not link to llvm,

---------------------------------------------------------------
ruffle.mk nightly-2025-08-24 # Version: Commits on Aug 24, 2025
---------------------------------------------------------------
## What's Changed

* debug_ui: Add layout debug information on EditTexts by @kjarosh in ruffle-rs/ruffle#21338

* exporter: Update --frames to accept \all\ to export all frames by @AeroXuk in ruffle-rs/ruffle#20930

* aur: Add aarch64 hash by @kjarosh in ruffle-rs/ruffle#21449

**Full Changelog**: ruffle-rs/ruffle@nightly-2025-08-23...nightly-2025-08-24,

-----------------------------------------------------------------------------------
ymir.mk 9a38f4aed78b8ae887bd121c83641ab106da7a31 # Version: Commits on Aug 20, 2025
-----------------------------------------------------------------------------------
feat(VDP1): Pixel-perfect rendering,

---------------------------------------------------------------------------------------
etlegacy.mk 7c58c15f1926d5117f66e558faf442f0f733263f # Version: Commits on Aug 23, 2025
---------------------------------------------------------------------------------------
github-actions: bumps version of signpath to 1.3,

-------------------------------------------------------------------------------------------
jazz2-native.mk 4540b7790bf7b3bf6814d4d480a83179248b9ff6 # Version: Commits on Aug 23, 2025
-------------------------------------------------------------------------------------------
Allow to drag&drop non-episode level to start it,

----------------------------------------------------------------------------------------
openmohaa.mk 5136eb38565c63a2931c29b25a974a28765d5c4c # Version: Commits on Aug 23, 2025
----------------------------------------------------------------------------------------
Add DEFAULT_RELATIVE_BASEDIR

Sys_BinaryPathRelative takes a parameter which is path concatenated with

Sys_BinaryPath, and resolved to a canonical path. The intended use case

is to facilitate the situation where you want the game data directory to

exist outside the same directory in which the binary lives, but relative

to it. More specifically, if you want to distriute multiple binaries for

different architectures, in the same tree, this allows for a means of

having said binaries in architecture subdirectories, with a shared data

directory, e.g.:

  ioq3/x86/ioquake3.exe etc.

  ioq3/x86_64/ioquake3.exe etc.

  ioq3/baseq3/pak0.pk3 etc.

Here, when building you would define DEFAULT_RELATIVE_BASEDIR=\..\ by

appending it to the build system CFLAGS, and then the executables will

by default look in their parent directory for the data.,

-----------------------------------------------------------------------------------
rott.mk 4653f0b5aadca1790fdc0b1b7bc174d1784f15bd # Version: Commits on Aug 23, 2025
-----------------------------------------------------------------------------------
Fix TARADINO_DATADIR CMake option comparison (#117)

In CMake, strings evaluate to false in the context of if commands.

Comparison against an empty string must be done explicitly.

Signed-off-by: Marcin Serwin <[email protected]>,

----------------------------------------------------------------------------------------
supertux2.mk 213df63197f0834cdaf4e93eb6350bf62c002f9d # Version: Commits on Aug 24, 2025
----------------------------------------------------------------------------------------
Update translations,

----------------------------------------------------------------------------------------
retroarch.mk 3f21e88f09621defc58f0a1e8e8eb87edbeb3729 # Version: Commits on Aug 24, 2025
----------------------------------------------------------------------------------------
apple: include ClownMDEmu in App Store builds,

-------------------------------------------------------------------------------------
libdof.mk abf2520db90c4fe9fcaa309d36111def1c34051e # Version: Commits on Aug 24, 2025
-------------------------------------------------------------------------------------
misc: fix deadlock crash when exiting (#20),

---------------------------------------------------------------------------------------
vpinball.mk 18c9d533dbaf03f2207f262ebf93015cf36dd1ce # Version: Commits on Jul 23, 2024
---------------------------------------------------------------------------------------
misc: standalone builds for macos, ios, tvos, android, linux, and rpi,

----------------------------------------------------------------------------------------
doomretro.mk 99fb42ebf3a0b5024d63ff2df0502cba13aeb443 # Version: Commits on Aug 24, 2025
----------------------------------------------------------------------------------------
Update releasenotes.md,

--------------------------------------------------------------------------------------------------
libretro-clownmdemu.mk 06e9d64ca46e884682fdc4044d84e2487da1c9e8 # Version: Commits on Aug 24, 2025
--------------------------------------------------------------------------------------------------
Correct CMake include path.,

----------------------------------------------------------------------------------------------
libretro-ppsspp.mk 79f222692428cc2fe775a2de2e18c416d2b9fb1b # Version: Commits on Aug 23, 2025
----------------------------------------------------------------------------------------------
Merge pull request #20737 from Samueru-sama/master

simplify deps install, use mesa that does not link to llvm,

---------------------------------------------------------------------------------------------
libretro-vba-m.mk 33c5aeb80e71419732d30be9695b062cb0fb710d # Version: Commits on Aug 23, 2025
---------------------------------------------------------------------------------------------
Default LCD Filter to enabled for GBA/GB

Set the defaults for GB and GBA LCD Filter to enabled and rewrite the

values in previous versions of the config to enabled as well.

Signed-off-by: Rafael Kitover <[email protected]>,
@danielhjacobs danielhjacobs removed the waiting-on-author Waiting on the PR author to make the requested changes label Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kjarosh kjarosh kjarosh approved these changes

Assignees

No one assigned

Labels

A-other Area: Not covered by other area labels exporter Issues related to the exporter tool T-feature Type: New Feature (that Flash doesn't have)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AeroXuk @kjarosh @danielhjacobs @Lord-McSweeney