-
Notifications
You must be signed in to change notification settings - Fork 130
Provide a non-owning constructor for Issuer
#362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(You might also be interested in #363.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can you squash your commits, please?
Gah! |
We normally use the merge queue, which doesn't make this easy, but we can bypass that if squashing is too hard for you. |
Aaaand squashed :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you :-)
Hey
rcgen
folks!I must say I really like what you've done with the new API changes, but I'm really missing a way to sign certificates without giving the issuer ownership of the
KeyPair
(especially frustrating since it's notClone
).Maybe I missed an alternative (maybe there's a newtype around a reference that directly impls
SigningKey
), but this seems like a straight forward enough change.Do keep in mind that if you accept this PR, you're probably locking yourself into having these
MaybeOwned
in the internal type representation (just thought I'd warn you :) ).Note: feel free to reject this PR if you don't want that extra surface, I'm gonna newtype
&KeyPair
to get that copy-less use in my project :)