Skip to content

Add a CertifiedIssuer #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2025
Merged

Add a CertifiedIssuer #363

merged 1 commit into from
Jul 4, 2025

Conversation

djc
Copy link
Member

@djc djc commented Jul 4, 2025

After upgrading a bunch of downstream code, this stands out as something that would make downstream code simpler.

@djc djc requested review from cpu and est31 July 4, 2025 07:44
@djc djc mentioned this pull request Jul 4, 2025
Merged
@djc djc force-pushed the certified-issuer branch from 6f55a25 to c33d514 Compare July 4, 2025 07:51
cpu
cpu approved these changes Jul 4, 2025
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I think this restores some small convenience that might have fallen away with previous refactorings to separate the private key from parameters.

@djc djc force-pushed the certified-issuer branch from c33d514 to 122a7d6 Compare July 4, 2025 12:47
@djc djc enabled auto-merge July 4, 2025 12:48
@djc djc added this pull request to the merge queue Jul 4, 2025
Merged via the queue into main with commit fe0ee64 Jul 4, 2025
14 of 16 checks passed
@djc djc deleted the certified-issuer branch July 4, 2025 13:02
@djc djc mentioned this pull request Jul 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpu cpu cpu approved these changes

@est31 est31 est31 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djc @cpu @est31