fix: prevent the deleted status from changing when processing #4198
+57
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overseerr
|
||||||||||||||||||||||||||||
| Project |
overseerr
|
| Branch Review |
refs/pull/4198/merge
|
| Run status |
|
| Run duration | 02m 23s |
| Commit |
|
| Committer | Brandon Cohen |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
28
|
| View all changes introduced in this branch ↗︎ | |
OwsleyJr
force-pushed
the
fix/delete-status
branch
from
3571aea to
46f7d20
Compare
…made" refactor: remove parent remove change until later date refactor: remove console log
OwsleyJr
force-pushed
the
fix/delete-status
branch
from
46f7d20 to
ccaa7da
Compare
1 task
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the DELETED media status was being unintentionally overwritten in the scanner logic. The change ensures that when media is marked as DELETED, the status is preserved even when the media still exists in radarr/sonarr or when all requests are removed.
- Modified the status update condition to preserve DELETED status alongside AVAILABLE status
- Prevents DELETED media from reverting to REQUESTED or UNKNOWN states inappropriately
fix: check if not processing first for movies
OwsleyJr
force-pushed
the
fix/delete-status
branch
from
0a42860 to
891a009
Compare
OwsleyJr
changed the title
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small PR that fixes a case where the DELETED status was being unintentionally overwritten. Also added download progress if a movie is processing after deleted:
Screenshot (if UI-related)
N/A
To-Dos
yarn build