Skip to content

Fixed ServerCORSTests #4239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fixed ServerCORSTests #4239

wants to merge 2 commits into from

Conversation

@sergiuszkierat
Copy link
Member

@sergiuszkierat sergiuszkierat commented Jan 8, 2025

No description provided.

@sergiuszkierat
Copy link
Member Author

sergiuszkierat commented Jan 8, 2025

Those tests should fail for Vert.x server as the bug says

@sergiuszkierat sergiuszkierat mentioned this pull request Jan 8, 2025
Merged
@sergiuszkierat
Copy link
Member Author

sergiuszkierat commented Jan 10, 2025

It turned out that ServerCORSTests which is widely used by AllServerTests had a bug. We registered OPTIONS endpoints and afterwards we were verifying a preflight request with Access-Control-Request-Method POST header against them. I've replace them by POST endpoint as we should expect that registered endpoint is POST as well.

Some of tests have failed, so my guess is that we should check if OPTIONS routing is active and able to handle preflight requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sergiuszkierat