Fixed ServerCORSTests #4239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft

sergiuszkierat wants to merge 2 commits into master from fix/cors_tests

server/tests/src/main/scala/sttp/tapir/server/tests/ServerCORSTests.scala

-Original file line number
+Diff line change
@@ Expand Up / @@ -22,14 +22,14 @@ @@
       val preflightTests = List(
         testServer(
-          endpoint.options.in("path").out(stringBody),
+          endpoint.post.in("path").out(stringBody),
           "CORS with default config; valid preflight request",
           _.corsInterceptor(CORSInterceptor.default[F])
         )(_ => pureResult("foo".asRight[Unit])) { (backend, baseUri) =>
           preflightRequest(baseUri)
             .send(backend)
             .map { response =>
               response.code shouldBe StatusCode.NoContent
               response.headers should contain allOf (
                 Header.accessControlAllowOrigin("*"),
                 Header.accessControlAllowMethods(CORSConfig.default.allowedMethods.asInstanceOf[AllowedMethods.Some].methods.toList: _*),
@@ Expand All / @@ -45,7 +45,7 @@ @@
             }
         },
         testServer(
-          endpoint.options.in("path"),
+          endpoint.post.in("path"),
           "CORS with specific allowed origin, method, headers, allowed credentials and max age; preflight request with matching origin, method and headers",
           _.corsInterceptor(
             CORSInterceptor.customOrThrow[F](
@@ Expand All / @@ -61,7 +61,7 @@ @@
           preflightRequest(baseUri)
             .send(backend)
             .map { response =>
               response.code shouldBe StatusCode.NoContent
               response.headers should contain allOf (
                 Header.accessControlAllowOrigin("https://example.com"),
                 Header.accessControlAllowMethods(Method.POST),
@@ Expand All / @@ -74,7 +74,7 @@ @@
             }
         },
         testServer(
-          endpoint.options.in("path"),
+          endpoint.post.in("path"),
           "CORS with multiple allowed origins, method, headers, allowed credentials and max age; preflight request with matching origin, method and headers",
           _.corsInterceptor(
             CORSInterceptor.customOrThrow[F](
@@ Expand All / @@ -90,7 +90,7 @@ @@
           preflightRequest(baseUri, "example2.com")
             .send(backend)
             .map { response =>
               response.code shouldBe StatusCode.NoContent
               response.headers should contain allOf (
                 Header.accessControlAllowOrigin("https://example2.com"),
                 Header.accessControlAllowMethods(Method.POST),
@@ Expand All / @@ -103,19 +103,19 @@ @@
             }
         },
         testServer(
-          endpoint.options.in("path"),
+          endpoint.post.in("path"),
           "CORS with specific allowed origin; preflight request with unsupported origin",
           _.corsInterceptor(CORSInterceptor.customOrThrow[F](CORSConfig.default.allowOrigin(Origin.Host("https", "example.com"))))
         )(noop) { (backend, baseUri) =>
           preflightRequest(baseUri, "unsupported.com")
             .send(backend)
             .map { response =>
               response.code shouldBe StatusCode.NoContent
               response.headers.map(_.name) should not contain (HeaderNames.AccessControlAllowOrigin)
             }
         },
         testServer(
-          endpoint.options.in("path"),
+          endpoint.post.in("path"),
           "CORS with multiple allowed origins; preflight request with unsupported origin",
           _.corsInterceptor(
             CORSInterceptor.customOrThrow[F](CORSConfig.default.allowMatchingOrigins(Set("https://example1.com", "https://example2.com")))
@@ Expand All / @@ -124,54 +124,54 @@ @@
           preflightRequest(baseUri, "unsupported.com")
             .send(backend)
             .map { response =>
               response.code shouldBe StatusCode.NoContent
               response.headers.map(_.name) should not contain (HeaderNames.AccessControlAllowOrigin)
             }
         },
         testServer(
-          endpoint.options.in("path"),
+          endpoint.post.in("path"),
           "CORS with specific allowed method; preflight request with unsupported method",
           _.corsInterceptor(CORSInterceptor.customOrThrow[F](CORSConfig.default.allowMethods(Method.PUT)))
         )(noop) { (backend, baseUri) =>
           preflightRequest(baseUri)
             .send(backend)
             .map { response =>
               response.code shouldBe StatusCode.NoContent
               response.headers.map(_.name) should not contain (HeaderNames.AccessControlAllowMethods)
             }
         },
         testServer(
-          endpoint.options.in("path"),
+          endpoint.post.in("path"),
           "CORS with specific allowed headers; preflight request with unsupported header",
           _.corsInterceptor(CORSInterceptor.customOrThrow[F](CORSConfig.default.allowHeaders("X-Bar")))
         )(noop) { (backend, baseUri) =>
           preflightRequest(baseUri)
             .send(backend)
             .map { response =>
               response.code shouldBe StatusCode.NoContent
               response.headers.map(_.name) should not contain (HeaderNames.AccessControlAllowHeaders)
             }
         },
         testServer(
-          endpoint.options.in("path"),
+          endpoint.post.in("path"),
           "CORS with reflected allowed headers; preflight request",
           _.corsInterceptor(CORSInterceptor.customOrThrow[F](CORSConfig.default.reflectHeaders))
         )(noop) { (backend, baseUri) =>
           preflightRequest(baseUri)
             .send(backend)
             .map { response =>
               response.code shouldBe StatusCode.NoContent
               response.headers should contain(Header.accessControlAllowHeaders("X-Foo"))
             }
         },
         testServer(
-          endpoint.options.in("path"),
+          endpoint.post.in("path"),
           "CORS with custom response code for preflight requests; valid preflight request",
           _.corsInterceptor(CORSInterceptor.customOrThrow[F](CORSConfig.default.preflightResponseStatusCode(StatusCode.Ok)))
         )(noop) { (backend, baseUri) =>
           preflightRequest(baseUri)
             .send(backend)
             .map(_.code shouldBe StatusCode.Ok)
         },
         testServer(
           endpoint.options.in("path"),
@@ Expand Down @@

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fixed ServerCORSTests #4239

Uh oh!

Diff view

Diff view

There are no files selected for viewing

GitHub Actions / Test report for 2.13-JVM-11

GitHub Actions / Test report for 3-JVM-11

GitHub Actions / Test report for 2.13-JVM-11

GitHub Actions / Test report for 3-JVM-11

GitHub Actions / Test report for 2.13-JVM-11

GitHub Actions / Test report for 3-JVM-11

GitHub Actions / Test report for 2.13-JVM-11

GitHub Actions / Test report for 3-JVM-11

GitHub Actions / Test report for 2.13-JVM-11

GitHub Actions / Test report for 3-JVM-11

GitHub Actions / Test report for 2.13-JVM-11

GitHub Actions / Test report for 3-JVM-11

GitHub Actions / Test report for 2.13-JVM-11

GitHub Actions / Test report for 3-JVM-11

GitHub Actions / Test report for 2.13-JVM-11

GitHub Actions / Test report for 3-JVM-11

GitHub Actions / Test report for 2.13-JVM-11

GitHub Actions / Test report for 3-JVM-11

Uh oh!

Fixed ServerCORSTests #4239

Are you sure you want to change the base?

Uh oh!

Fixed ServerCORSTests #4239

Uh oh!

Uh oh!

Diff view

Diff view

There are no files selected for viewing

GitHub Actions / Test report for 2.13-JVM-11

GitHub Actions / Test report for 3-JVM-11

GitHub Actions / Test report for 2.13-JVM-11

GitHub Actions / Test report for 3-JVM-11

GitHub Actions / Test report for 2.13-JVM-11

GitHub Actions / Test report for 3-JVM-11

GitHub Actions / Test report for 2.13-JVM-11

GitHub Actions / Test report for 3-JVM-11

GitHub Actions / Test report for 2.13-JVM-11

GitHub Actions / Test report for 3-JVM-11

GitHub Actions / Test report for 2.13-JVM-11

GitHub Actions / Test report for 3-JVM-11

GitHub Actions / Test report for 2.13-JVM-11

GitHub Actions / Test report for 3-JVM-11

GitHub Actions / Test report for 2.13-JVM-11

GitHub Actions / Test report for 3-JVM-11

GitHub Actions / Test report for 2.13-JVM-11

GitHub Actions / Test report for 3-JVM-11

Uh oh!