Fix Order by (and Issue 81 onsnapshot implementation) #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aChanges is true.
…l the onSnapshot callbacks no mater where the flush is called from.
* issue-81-onsnapshot: Move onSnapshot handers to the queue so that a call to flush will call the onSnapshot callbacks no mater where the flush is called from. onSnapshot should call callback if no data changed and includeMetadataChanges is true. Add onSnapshot functionality to doc, collection and query
* issue-81-onsnapshot: onSnapshot should call immediatly and then after data changes.
|
Oops. It looks like I based my fixed pull-request (#158) on your old I'd rebase my changes on this pull-request, except it looks like @soumak77 is not currently active on evaluating/merging pull-requests. Anyway, this pull-request adds basic onSnapshot support + orderBy for it, whereas mine (#158) adds basic onSnapshot support + fixes for two broken cases. I don't need orderBy currently so am too lazy to update my branch, but if @soumak77 returns to take a look at the pull-requests, I can do the rebasing procedure mentioned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the Orderby conflicted with changes in PR #130 (the onsnapshot implementation) so this is a merge of both changes. Probably can close pull #130 if this gets merged in.