Skip to content

Fix Order by (and Issue 81 onsnapshot implementation) #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fix Order by (and Issue 81 onsnapshot implementation) #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1fade31
Add onSnapshot functionality to doc, collection and query
BrianChapman Jan 23, 2019
57643cc
onSnapshot should call callback if no data changed and includeMetadat…
BrianChapman Jan 23, 2019
65a9ddf
Move onSnapshot handers to the queue so that a call to flush will cal…
BrianChapman Jan 25, 2019
5882b18
Fix orderBy sorting behavior.
BrianChapman Apr 24, 2019
b593d85
Merge branch 'issue-81-onsnapshot' into orderBy-onsnapshot-merge
BrianChapman Apr 24, 2019
27e7f8f
onSnapshot should call immediatly and then after data changes.
BrianChapman Apr 25, 2019
011dcc7
Merge branch 'issue-81-onsnapshot' into orderBy-onsnapshot-merge
BrianChapman Apr 25, 2019
3625e07
Allow queries to chain, eg: query.limit(3).where(..).get()
BrianChapman Apr 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,5 @@ If you've encountered a bug or want to request new functionality, go ahead and f
* make your additions in `./src`
* Do not edit the files in `./browser`. They are built automatically for releases. [@bendrucker](https://github.com/bendrucker) will have to spend time rebasing your PR and that makes him :cry:.
* add test units in `./test`
* `npm test`
* `npm test` (node version < 8)
* submit a pull request when all tests pass
Loading