feat: visual design for disabled state of mcp servers page #894
+569
−329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements a visual design for the disabled state of MCP servers page. The changes introduce conditional UI states based on whether a group has registered clients, showing visual feedback and appropriate actions for disabled groups.
- Adds visual styling (opacity and grayscale) for MCP server cards when groups are disabled
- Conditionally renders management buttons based on group state
- Introduces a new "Enable Group" button for disabled groups
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| renderer/src/routes/group.$groupName.tsx | Adds logic to determine if group is disabled and conditionally renders buttons |
| renderer/src/routes/tests/group.$groupName.menu.confirm.test.tsx | Adds test coverage for disabled group UI states and updates existing tests |
| renderer/src/features/mcp-servers/components/grid-cards-mcp-server.tsx | Passes disabled state prop to individual cards |
| renderer/src/features/mcp-servers/components/card-mcp-server/index.tsx | Applies visual styling for disabled state |
| renderer/src/features/clients/hooks/use-manage-clients-dialog.tsx | Extracts reusable dialog logic for managing clients |
| renderer/src/features/clients/components/manage-clients-button.tsx | Refactors to use extracted dialog hook |
| renderer/src/features/clients/components/enable-group-button.tsx | New component for enabling disabled groups |
| renderer/src/features/clients/components/tests/manage-clients-button.test.tsx | Removes outdated comments from test file |
| renderer/src/features/clients/components/tests/enable-group-button.test.tsx | Adds test coverage for the new enable group functionality |
| renderer/src/common/components/ui/button.tsx | Adds new "enable" variant styling for buttons |
kantord
changed the title
peppescg
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Record_select-area_20250917171525.mp4
Fallback logic when the groups feature flag is disabled:
in other words, the new design is rolled out even when the feature flag is disabled, but with a slightly different wording