feat: add session management for proxy #1081
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JAORMX
reviewed
Jul 16, 2025
dmjb
reviewed
Jul 16, 2025
dmjb
reviewed
Jul 16, 2025
dmjb
reviewed
Jul 16, 2025
dmjb
reviewed
Jul 16, 2025
dmjb
reviewed
Jul 16, 2025
dmjb
reviewed
Jul 16, 2025
dmjb
reviewed
Jul 16, 2025
dmjb
reviewed
Jul 16, 2025
dmjb
reviewed
Jul 16, 2025
yrobla
force-pushed
the
issue-1078
branch
3 times, most recently
from
a7f4b00 to
010e789
Compare
dmjb
requested changes
Jul 17, 2025
yrobla
force-pushed
the
issue-1078
branch
3 times, most recently
from
293c715 to
b142eb1
Compare
dmjb
previously requested changes
Jul 18, 2025
Adds a session interface to proxy, and initialize with the extracted session id from transport messages Only enable healthchecks when we detect that the server has been initialized Closes: #1078
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Copilot <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
dmjb
approved these changes
Jul 22, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds session management capabilities to the transparent proxy to track MCP sessions and conditionally enable health checks. The implementation extracts session IDs from transport messages (both headers and SSE streams) and only enables health monitoring once the server has been initialized.
Key changes include:
- Session management infrastructure with TTL-based cleanup for proxy sessions
- Session ID detection from HTTP headers and Server-Sent Events (SSE) streams
- Conditional health check activation based on server initialization state
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/transport/session/proxy_session.go | Implements ProxySession struct with session tracking capabilities |
| pkg/transport/session/manager.go | Core session manager with TTL cleanup and thread-safe operations |
| pkg/transport/session/manager_test.go | Comprehensive test suite for session manager functionality |
| pkg/transport/proxy/transparent/transparent_proxy.go | Enhanced proxy with session detection and conditional health checks |
| pkg/transport/proxy/transparent/transparent_test.go | Tests for session ID detection in SSE and header scenarios |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a session interface to proxy, and initialize with the extracted session id from transport messages
Only enable healthchecks when we detect that the server has been initialized
Closes: #1078